ARROW-10085: [C++] Fix S3 region resolution on Windows #8261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid trying to following redirects when resolving a region, as that can fail (at least on Windows with certain AWS SDK versions). Also skip a test that's failing because of a bug in the AWS SDK on Windows.
pitrou
commented
Sep 24, 2020
|
CI failures are unrelated. |
bkietz
reviewed
Sep 24, 2020
|
@github-actions crossbow submit homebrew-r-autobrew |
|
Revision: e199de1 Submitted crossbow builds: ursa-labs/crossbow @ actions-553
|
bkietz
approved these changes
Sep 24, 2020
|
Passing Travis: https://travis-ci.org/github/pitrou/arrow/builds/730048965 |
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
Avoid trying to following redirects when resolving a region, as that can fail (at least on Windows with certain AWS SDK versions). Also skip a test that's failing because of a bug in the AWS SDK on Windows. Closes apache#8261 from pitrou/ARROW-10085-s3-redirects Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Avoid trying to following redirects when resolving a region, as that can fail (at least on Windows with certain AWS SDK versions). Also skip a test that's failing because of a bug in the AWS SDK on Windows. Closes apache#8261 from pitrou/ARROW-10085-s3-redirects Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid trying to following redirects when resolving a region, as that can fail
(at least on Windows with certain AWS SDK versions).
Also skip a test that's failing because of a bug in the AWS SDK on Windows.