ARROW-1125: Python: Add public C++ API to unwrap PyArrow object #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I333d13016475aee86df57cb83d24eaac1582b8da
Change-Id: Icd7cf12719f143d5d63aa6b7c46af7b6d230b5f0
Change-Id: I43748f8616a3a68f0849c34dca7dc59ade5c1a5a
Change-Id: I127c51caffefac474b6f60781121f5fed5a1fb23
cpcloud
reviewed
Jul 10, 2017
| field_ = <Field>(field) | ||
| return field_.sp_field | ||
|
|
||
| return shared_ptr[CField]() |
There was a problem hiding this comment.
Is this the same as returning nullptr?
There was a problem hiding this comment.
Yes, nullptr would only invoke the default constructor and return the same object.
cpcloud
reviewed
Jul 10, 2017
| return isinstance(buffer, Buffer) | ||
|
|
||
|
|
||
| cdef public api shared_ptr[CBuffer] pyarrow_unwrap_buffer(object buffer): |
There was a problem hiding this comment.
Is there any reason not to give the arguments stronger types here? Like:
... pyarrow_unwrap_buffer(Buffer buffer)There was a problem hiding this comment.
This is not allowed in api functions:
Function declared public or api may not have private types
wesm
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.