ARROW-10336: [Rust] Added FromIter and ToIter for string arrays #8486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vertexclique
approved these changes
Oct 20, 2020
|
@vertexclique , do you refer to the |
| } | ||
| } | ||
|
|
||
| impl<'a, Ptr, OffsetSize: StringOffsetSizeTrait> FromIterator<Ptr> |
There was a problem hiding this comment.
I meant type params like:
Suggested change
| impl<'a, Ptr, OffsetSize: StringOffsetSizeTrait> FromIterator<Ptr> | |
| impl<'a, P, OS: StringOffsetSizeTrait> FromIterator<P> |
There was a problem hiding this comment.
I see. I have no strong feelings about it, I just think that explicit is better than implicit, and P or OS forces the reader to go to the where clause to understand what they mean. OTOH, generics are generics, and also rust seems to prefer one-letter generic types.
I will leave it like this just because the rest of the code base around offsets is like this.
There was a problem hiding this comment.
Happy with it as is, if we need to change, we can do that for the whole module/codebase in future
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
What the title says: adds string array from and to iterators. This PR also simplifies some of the functions around strings. Closes apache#8486 from jorgecarleitao/from_opt_vec_str Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com> Signed-off-by: Neville Dipale <nevilledips@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the title says: adds string array from and to iterators.
This PR also simplifies some of the functions around strings.