-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-10392: [C++][Gandiva] Avoid string copy while evaluating IN expression #8530
Conversation
@github-actions crossbow submit -g gandiva |
Revision: 84515e8 Submitted crossbow builds: ursa-labs/crossbow @ actions-680
|
still couldn't avoid string copy - the copy is now happening inside HashTable
@bkietz , any reason why the copy is happening even when we are looking for a string_view in hashtable<string_view>? |
Turns out string_view hash function internally creates a string |
@github-actions crossbow submit -g gandiva |
Revision: eec6dfd Submitted crossbow builds: ursa-labs/crossbow @ actions-682
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, any idea what is causing the linker errors?
MinGW link problem is caused by msys2/MINGW-packages#7170 . |
…ression Closes apache#8530 from pprudhvi/stringalloc Authored-by: Prudhvi Porandla <prudhvi.porandla@icloud.com> Signed-off-by: Pindikura Ravindra <ravindra@dremio.com>
…ression Closes apache#8530 from pprudhvi/stringalloc Authored-by: Prudhvi Porandla <prudhvi.porandla@icloud.com> Signed-off-by: Pindikura Ravindra <ravindra@dremio.com>
…ression (#19) Closes apache#8530 from pprudhvi/stringalloc Authored-by: Prudhvi Porandla <prudhvi.porandla@icloud.com> Signed-off-by: Pindikura Ravindra <ravindra@dremio.com>
…ression Closes apache#8530 from pprudhvi/stringalloc Authored-by: Prudhvi Porandla <prudhvi.porandla@icloud.com> Signed-off-by: Pindikura Ravindra <ravindra@dremio.com>
No description provided.