ARROW-10499: [C++][Java] Fix ORC Java JNI Crash #8595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`OrcStripeReaderJniWrapper::getSchema` previously used `nullptr` for the memory pool parameter to `arrow::ipc::SerializeSchema` to implicitly call `arrow::default_memory_pool()`. As part of https://issues.apache.org/jira/browse/ARROW-10080, a check was placed to fail on `nullptr` being provided. This change removes the check, but also explicitly calls `arrow::default_memory_pool()` which is used elsewhere in the JNI wrapper.
|
LGTM |
|
@kiszk you mind merging this in? Not sure if anything else needs to happen, but I don't have write access to the repo 🙂 |
|
I do not have the grant to merge it, too. I expect that others will look at this. |
|
Thanks for fixing this @terencehonles ! |
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
`OrcStripeReaderJniWrapper::getSchema` previously used `nullptr` for the memory pool parameter to `arrow::ipc::SerializeSchema` to implicitly call `arrow::default_memory_pool()`. As part of ARROW-10080 (apache#8533), a check was placed to fail on `nullptr` being provided. This change removes the check, but also explicitly calls `arrow::default_memory_pool()` which is used elsewhere in the JNI wrapper. Closes apache#8595 from terencehonles/arrow-10499 Authored-by: Terence D. Honles <terence@honles.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrcStripeReaderJniWrapper::getSchemapreviously usednullptrfor the memory pool parameter toarrow::ipc::SerializeSchemato implicitly callarrow::default_memory_pool().As part of ARROW-10080 (#8533), a check was placed to fail on
nullptrbeing provided. This change removes the check, but also explicitly callsarrow::default_memory_pool()which is used elsewhere in the JNI wrapper.