ARROW-10535: [Rust] Implement bit & byte slice iterator for big endian platforms #8634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vertexclique
added a commit
to vertexclique/arrow
that referenced
this pull request
Nov 10, 2020
This was referenced Nov 11, 2020
vertexclique
added a commit
to vertexclique/arrow
that referenced
this pull request
Nov 14, 2020
nevi-me
requested changes
Nov 15, 2020
| @@ -0,0 +1,108 @@ | |||
| #[cfg(all(test, target_endian = "big"))] | |||
There was a problem hiding this comment.
File needs license header @vertexclique
There was a problem hiding this comment.
I think it will come from here Neville https://github.com/apache/arrow/pull/8664/files#diff-715ddfbc534281523a73117d3bf4986d69d8a375dd320bc19f83298d3ba7ebd6R1
I will rebase this branch on top of that one, waiting for it to be merged.
|
@vertexclique -- Given the imminent Arrow 3.0 release, I am trying to clean up older Rust PRs and see if the authors have plans to move them forward. Do you plan on working on this PR in the near future? If not, should we close this PR until there is time to make progress? Thanks again for your contributions so far. |
|
@alamb Thanks for reaching out! I don't have time to work on these PRs. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.