ARROW-10566: [C++] Allow validating ArrayData directly #8652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkietz
requested changes
Nov 12, 2020
| } | ||
| // Check offsets are in bounds | ||
| const int32_t* offsets = data.GetValues<int32_t>(2); | ||
| for (int64_t i = 0; i < data.length; ++i) { | ||
| const int32_t code = type_codes[i]; | ||
| const int32_t offset = offsets[i]; | ||
| if (offset < 0) { |
There was a problem hiding this comment.
We should probably also validate that the offsets are strictly increasing
There was a problem hiding this comment.
No, that's not required for unions. cc @wesm
There was a problem hiding this comment.
https://arrow.apache.org/docs/format/Columnar.html#dense-union
"The respective offsets for each child value array must be in order / increasing."
There was a problem hiding this comment.
Doesn't need to happen in this PR: https://issues.apache.org/jira/browse/ARROW-10580
Having to construct an Array from ArrayData entails various assertions which may fail. It is therefore safer to be able to validate the data *before*.
pitrou
force-pushed
the
ARROW-10566-validate-data
branch
from
204e000
to
3952519
Compare
bkietz
approved these changes
Nov 13, 2020
yordan-pavlov
pushed a commit
to yordan-pavlov/arrow
that referenced
this pull request
Nov 14, 2020
Having to construct an Array from ArrayData entails various assertions which may fail. It is therefore safer to be able to validate the data *before*. Closes apache#8652 from pitrou/ARROW-10566-validate-data Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Having to construct an Array from ArrayData entails various assertions which may fail. It is therefore safer to be able to validate the data *before*. Closes apache#8652 from pitrou/ARROW-10566-validate-data Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
This was referenced Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to construct an Array from ArrayData entails various assertions which may fail.
It is therefore safer to be able to validate the data before.