ARROW-10609: [Rust] Optimize min/max of non null strings #8673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+39
to
44
| for i in 1..data.len() { | ||
| let item = array.value(i); | ||
| if !has_value || cmp(&n, item) { | ||
| has_value = true; | ||
| if cmp(&n, item) { | ||
| n = item; | ||
| } | ||
| } |
There was a problem hiding this comment.
Feels like this code can use fold with your changes now.
There was a problem hiding this comment.
I translated the other min_max_helper into using fold. couldn't figure out to convert min_max_string to use fold here.
|
Liked it, can you address the comments, that will make some improvements on the benches indirectly. |
jorgecarleitao
approved these changes
Nov 16, 2020
|
CI failure seems to be infrastructure related: https://github.com/apache/arrow/pull/8673/checks?check_run_id=1408484265 I re-triggered the job in the github CI and will hope it will pass this time |
|
The TravisCI builds are not affected by Rust, so merging this one in |
alamb
approved these changes
Nov 16, 2020
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Applies the same optimization as in ARROW-10595. Difference is smaller, but still there:
```
min string 512 time: [3.4096 us 3.4378 us 3.4683 us]
change: [-13.563% -13.111% -12.628%] (p = 0.00 < 0.05)
Performance has improved.
```
Closes apache#8673 from Dandandan/min_max_string
Authored-by: Heres, Daniel <danielheres@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the same optimization as in ARROW-10595. Difference is smaller, but still there: