New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float #8674
Conversation
Did you report the issue upstream? |
Not yet. I will report this issue today. |
Reported at https://github.com/lemire/fast_float/issues/37 |
We are looking into fixing this upstream (big endian support). |
(The hard part is to add the necessary CI testing.) |
(I managed to add CI tests now.) |
The issue has been fixed upstream (big endian support). I am running exhaustive tests and once they complete, I will issue a new release. If you wish, you can wait for this new release instead of merging a vendored change. |
Travis CI has s390x architecture (that's how we've been testing on BE) |
Version 0.2.0 of fast_float is out: https://github.com/lemire/fast_float/releases/tag/v0.2.0 Release notes:
|
@pitrou Will you open another PR to integrate ver. 0.2.0 of fast_float? |
@kiszk I will, unless you beat me to it. |
@pitrou Sounds good, I will close this PR. |
This PR is a follow-up of #8494 . The fast_float vendor library does not support big-endian of exponential float notion in
from_chars
. This PR correctly copies the available 32-bit (offset 4-7 on big-endian) to the result.