Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-10216: [Rust] Simd implementation for primitive min/max kernels #8685

Closed
wants to merge 19 commits into from
Closed

ARROW-10216: [Rust] Simd implementation for primitive min/max kernels #8685

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b00216b
ARROW-10216 Refactoring and simd implementation of min aggregate kernel
jhorstmann Nov 16, 2020
646813c
ARROW-10216 Assertion in range of machine epsilon
vertexclique Nov 6, 2020
d37d0b4
ARROW-10216 Add max aggregate and adjust epsilon in assertions
jhorstmann Nov 16, 2020
a9f4a2b
ARROW-10216 Add datafusion benchmark for min/max aggregation
jhorstmann Nov 16, 2020
dbe0889
ARROW-10216 Add comments in ArrowNumericType
jhorstmann Nov 16, 2020
ae1ffde
ARROW-10216 Formatting
jhorstmann Nov 16, 2020
9db18dc
ARROW-10216 Comments
jhorstmann Nov 16, 2020
9f20b4c
ARROW-10216 Add tests for min/max aggregate and fix bug in simd mask …
jhorstmann Nov 18, 2020
2cd5730
Merge remote-tracking branch 'origin/master' into ARROW-10216-simd-op…
jhorstmann Nov 18, 2020
a1b9482
ARROW-10216 Clippy fixes
jhorstmann Nov 18, 2020
35473ab
ARROW-10216 Rewrite vector mask tests
jhorstmann Nov 18, 2020
0100e76
ARROW-10216 Add tests involving infinities and nan
jhorstmann Nov 20, 2020
5dba3e2
ARROW-10216 Refactor to track validity of each vector lane when aggre…
jhorstmann Nov 29, 2020
38213b2
ARROW-10216 Clippy fixes
jhorstmann Dec 6, 2020
cae8554
ARROW-10216 Remove comments about ignored tests
jhorstmann Dec 6, 2020
a462eac
Merge remote-tracking branch 'upstream/master' into ARROW-10216-simd-…
jhorstmann Dec 6, 2020
a9f3b61
ARROW-10216 Remove no longer needed trait bounds
jhorstmann Dec 6, 2020
0aea325
ARROW-10216 Improve comments and variable names
jhorstmann Dec 6, 2020
9beb585
ARROW-10216 Comments for vector mask calculation
jhorstmann Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions rust/arrow/benches/aggregate_kernels.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ fn bench_min(arr_a: &Float32Array) {
criterion::black_box(min(&arr_a).unwrap());
}

fn bench_max(arr_a: &Float32Array) {
criterion::black_box(max(&arr_a).unwrap());
}

fn bench_min_string(arr_a: &StringArray) {
criterion::black_box(min_string(&arr_a).unwrap());
}
Expand All @@ -78,11 +82,13 @@ fn add_benchmark(c: &mut Criterion) {

c.bench_function("sum 512", |b| b.iter(|| bench_sum(&arr_a)));
c.bench_function("min 512", |b| b.iter(|| bench_min(&arr_a)));
c.bench_function("max 512", |b| b.iter(|| bench_max(&arr_a)));

let arr_a = create_array(512, true);

c.bench_function("sum nulls 512", |b| b.iter(|| bench_sum(&arr_a)));
c.bench_function("min nulls 512", |b| b.iter(|| bench_min(&arr_a)));
c.bench_function("max nulls 512", |b| b.iter(|| bench_max(&arr_a)));

let arr_b = create_string_array(512, false);
c.bench_function("min string 512", |b| b.iter(|| bench_min_string(&arr_b)));
Expand Down