ARROW-10745: [Rust] Directly allocate padding bytes in filter context #8779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevi-me
approved these changes
Nov 27, 2020
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
A thing I noticed while going through some code. When creating a`MutableBuffer` here only `filter_bytes.len()` are being allocated, but the capacity can afterwards being increased when adding bytes using `extend_from_slice`. This changes it to allocate those bytes directly. Closes apache#8779 from Dandandan/allocate_padding Authored-by: Heres, Daniel <danielheres@gmail.com> Signed-off-by: Neville Dipale <nevilledips@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A thing I noticed while going through some code.
When creating a
MutableBufferhere onlyfilter_bytes.len()are being allocated, but the capacity can afterwards being increased when adding bytes usingextend_from_slice.This changes it to allocate those bytes directly.