Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-10604: [GLib][Ruby] Add support for 256-bit decimal #8919

Closed
wants to merge 12 commits into from
Closed

ARROW-10604: [GLib][Ruby] Add support for 256-bit decimal #8919

wants to merge 12 commits into from

Conversation

kou
Copy link
Member

@kou kou commented Dec 15, 2020

No description provided.

@kou kou requested review from mrkn and shiro615 December 15, 2020 00:44
@kou
Copy link
Member Author

kou commented Dec 15, 2020

@emkornfield I noticed that Decimal256 doesn't provide the following APIs that are provided for Decimal128. Is it intended?

  • explicit operator int64_t()
  • operator+()
  • operator-()

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-10604

@emkornfield
Copy link
Contributor

@kou I'm still working on adding some of these. If these are ones that ruby requires I'll work on those next. (operator+ should be done in #8897 and operator- will be trivial to add as well.

@kou
Copy link
Member Author

kou commented Dec 15, 2020

@emkornfield Thanks for sharing the current status! They're not required so far. I'll add support for them to Ruby when you're done.

mrkn
mrkn reviewed Dec 15, 2020
View reviewed changes
c_glib/arrow-glib/basic-data-type.cpp Outdated Show resolved Hide resolved
c_glib/arrow-glib/decimal.cpp Show resolved Hide resolved
ruby/red-arrow/lib/arrow/array-builder.rb Outdated Show resolved Hide resolved
ruby/red-arrow/lib/arrow/decimal256.rb Show resolved Hide resolved
@mrkn
Copy link
Member

mrkn commented Dec 19, 2020

@kou I released bigdecimal 2.0.3 and 3.0.0. Both versions support BigDecimal#precision.

@kou
Copy link
Member Author

kou commented Dec 19, 2020

Thanks.
I've changed to use bigdecimal 2.0.3 or later.

@kou
Copy link
Member Author

kou commented Dec 21, 2020

+1

@kou kou closed this in bcb3c1b Dec 21, 2020
@kou kou deleted the glib-decimal256 branch December 21, 2020 00:58
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
@kou @GeorgeAp
ARROW-10604: [GLib][Ruby] Add support for 256-bit decimal
f1a15e0 
Closes apache#8919 from kou/glib-decimal256

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@asfimport asfimport mentioned this pull request Dec 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrkn mrkn mrkn left review comments

@shiro615 shiro615 Awaiting requested review from shiro615

Assignees
No one assigned
Labels
Component: C++ Component: GLib Component: Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kou @emkornfield @mrkn