ARROW-10946: [Rust] Simplified bit chunk iterator #8942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 I like the simplification. Any (expected) change in performance? I think the CI is failing because of a change for parquet that was just reverted. So I guess it will just succeed in the new run. |
Dandandan
approved these changes
Dec 16, 2020
|
Looks good 👍 |
Nop, |
nevi-me
approved these changes
Dec 22, 2020
Dandandan
pushed a commit
to Dandandan/arrow
that referenced
this pull request
Dec 22, 2020
This PR makes the bit chunk iterator not depend on a `Buffer`, since we were only using it to keep track of the lifetime, and we can just use a byte slice for it. Closes apache#8942 from jorgecarleitao/improve_chunk_iter Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com> Signed-off-by: Neville Dipale <nevilledips@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
This PR makes the bit chunk iterator not depend on a `Buffer`, since we were only using it to keep track of the lifetime, and we can just use a byte slice for it. Closes apache#8942 from jorgecarleitao/improve_chunk_iter Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com> Signed-off-by: Neville Dipale <nevilledips@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the bit chunk iterator not depend on a
Buffer, since we were only using it to keep track of the lifetime, and we can just use a byte slice for it.