ARROW-11100: [Rust] Speed up numeric to string cast using lexical_core #9068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9068 +/- ##
==========================================
+ Coverage 82.55% 82.61% +0.05%
==========================================
Files 203 204 +1
Lines 50043 49942 -101
==========================================
- Hits 41313 41259 -54
+ Misses 8730 8683 -47
Continue to review full report at Codecov.
|
jorgecarleitao
approved these changes
Jan 2, 2021
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Uses lexical_core to speed up num to string casts.
This gets a nice speed up, especially for floats:
```
cast i64 to string 512 time: [22.209 us 22.462 us 22.885 us]
change: [-38.438% -37.979% -37.154%] (p = 0.00 < 0.05)
Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
11 (11.00%) low mild
3 (3.00%) high severe
Benchmarking cast f32 to string 512: Collecting 100 samples in estimated 5.0698 cast f32 to string 512 time: [25.587 us 25.692 us 25.786 us]
change: [-62.364% -62.215% -62.076%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low severe
1 (1.00%) low mild
4 (4.00%) high mild
1 (1.00%) high severe
```
Closes apache#9068 from Dandandan/numeric_cast_lexical
Authored-by: Heres, Daniel <danielheres@gmail.com>
Signed-off-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses lexical_core to speed up num to string casts.
This gets a nice speed up, especially for floats: