ARROW-11101: [Rust] rewrite pre-commit hook #9072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9072 +/- ##
=======================================
Coverage 82.55% 82.55%
=======================================
Files 203 203
Lines 50043 50043
=======================================
+ Hits 41313 41315 +2
+ Misses 8730 8728 -2
Continue to review full report at Codecov.
|
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Currently, the client side git pre-commit hook checks and runs `cargo fmt` with stable version, but the CI check may fail in nightly version occasionally even if the code has been formatted with stable. It seems that, this problem can be resolved by: running `cargo +nighty fmt` before `cargo +stable fmt`. Thus `pre-commit.sh` should be updated in this way. In this PR: 1. only check staged *.rs files and exit if no changes 2. cargo clippy is moved before cargo fmt 3. run `cargo +nighty fmt` before cargo +stable fmt 4. show more concise tip messages 5. abort the commit if there are files changed by `cargo fmt` Closes apache#9072 from mqy/rewrite-pre-commit-hook Authored-by: mqy <meng.qingyou@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the client side git pre-commit hook checks and runs
cargo fmtwith stable version, but the CI check may fail in nightly version occasionally even if the code has been formatted with stable.It seems that, this problem can be resolved by: running
cargo +nighty fmtbeforecargo +stable fmt. Thuspre-commit.shshould be updated in this way.In this PR:
cargo +nighty fmtbefore cargo +stable fmtcargo fmt