ARROW-11137: [Rust][DataFusion] Clippy needless_range_loop,needless_lifetimes #9106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 5, 2021
| @@ -138,8 +138,8 @@ impl ExecutionPlan for RepartitionExec { | |||
| } | |||
|
|
|||
| // notify each output partition that this input partition has no more data | |||
| for i in 0..num_output_partitions { | |||
| let tx = &mut channels[i].0; | |||
| for channel in channels.iter_mut().take(num_output_partitions) { | |||
There was a problem hiding this comment.
This can probably be even simpler as I think channels always has num_output_partitions elemements:
Suggested change
| for channel in channels.iter_mut().take(num_output_partitions) { | |
| for channel in channels.iter_mut() { |
But this PR's code is a correct as what was previously here :)
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…ifetimes Fixes: * clippy::needless_lifetimes, * clippy::needless_range_loop Closes apache#9106 from Dandandan/clippy_5 Authored-by: Heres, Daniel <danielheres@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: