New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-11706: [JS] Better BigInt compatibility check #9110
Conversation
Check for whether `BigInt64ArrayAvailable` and `BigUint64ArrayAvailable` are available, rather than just `BigIntAvailable`. Recent versions of JavaScriptCore/WebKit in Safari support `BigInt` but do not support `BigInt64Array`, and so anything that relies on `BigInt64Array` will fail despite `BigIntAvailable` being `true`.
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format?
See also: |
The manifestation of this issue can be seen when trying to run the following within Safari on a table that contains bigints: RecordBatchJSONWriter.writeAll(table).toString(true)
|
d4608a9
to
356c300
Compare
Thanks for the pull request! I've created a Jira ticket for you: If you could update the PR subject to Thanks again & stay safe! |
@trxcllnt Can we merge this? @marcprux Could you tell us your JIRA account? I want to assign you to https://issues.apache.org/jira/browse/ARROW-11706 . |
@trxcllnt said that instead of this change, we should remove the JSON IPC classes from the npm packages and only have them in the integration tests. Can we close this pull request? |
Check for whether
BigInt64ArrayAvailable
andBigUint64ArrayAvailable
are available, rather than justBigIntAvailable
. Recent versions of JavaScriptCore/WebKit in Safari supportBigInt
but do not supportBigInt64Array
, and so anything that relies onBigInt64Array
will fail despiteBigIntAvailable
beingtrue
.