ARROW-11136: [R] Bindings for is.nan #9167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealrichardson
requested changes
Jan 11, 2021
r/tests/testthat/test-dataset.R
Outdated
| expect_equivalent( | ||
| ds %>% | ||
| select(part, dbl) %>% | ||
| filter(!is.nan(dbl), part == 1) %>% |
There was a problem hiding this comment.
I'm not sure this is a great test because the NaN you added looks like it is in part == 2
| @@ -111,7 +111,8 @@ cast_array_expression <- function(x, to_type, safe = TRUE, ...) { | |||
|
|
|||
| .unary_function_map <- list( | |||
| "!" = "invert", | |||
| "is.na" = "is_null" | |||
| "is.na" = "is_null", | |||
| "is.nan" = "is_nan" | |||
There was a problem hiding this comment.
It's beautiful that this is the only change needed to support this in the dplyr code.
There was a problem hiding this comment.
Yeah, absolutely! There's more testing in this PR than operational code :)
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
nealrichardson
approved these changes
Jan 13, 2021
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Closes apache#9167 from jonkeane/ARROW-11136-is.nan Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.