ARROW-11329: [Rust] Don't rerun build.rs on every file change #9277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up development by avoiding rebuilding the whole library when any file in the package directory is touched.
jorgecarleitao
changed the title
jorgecarleitao
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
Hey @mbrubeck , super happy to have you here, and thank you for your contribution!!
I created a issue on JIRA and changed the title to match it, I hope that is ok.
paddyhoran
approved these changes
Jan 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #9277 +/- ##
==========================================
- Coverage 81.68% 81.65% -0.04%
==========================================
Files 215 215
Lines 52561 52410 -151
==========================================
- Hits 42935 42795 -140
+ Misses 9626 9615 -11
Continue to review full report at Codecov.
|
kszucs
pushed a commit
that referenced
this pull request
Jan 25, 2021
This speeds up development by avoiding rebuilding the whole library when any file in the package directory is touched. Closes #9277 from mbrubeck/build Authored-by: Matt Brubeck <mbrubeck@limpet.net> Signed-off-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
This speeds up development by avoiding rebuilding the whole library when any file in the package directory is touched. Closes apache#9277 from mbrubeck/build Authored-by: Matt Brubeck <mbrubeck@limpet.net> Signed-off-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
This speeds up development by avoiding rebuilding the whole library when any file in the package directory is touched. Closes apache#9277 from mbrubeck/build Authored-by: Matt Brubeck <mbrubeck@limpet.net> Signed-off-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up development by avoiding rebuilding the whole library
when any file in the package directory is touched.