-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-11341: [Python] [Gandiva] Add NULL/None checks to Gandiva builder functions #9289
ARROW-11341: [Python] [Gandiva] Add NULL/None checks to Gandiva builder functions #9289
Conversation
3b5b11e
to
80dcd11
Compare
d4608a9
to
356c300
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about you add an unit test with none node that originally segfaults.
80dcd11
to
3e2cdb1
Compare
Good call on the tests. Looks like we are still getting a segfault. I will look into that later today. |
@projjal Should be good to review now. |
2bf5d93
to
4df1118
Compare
@jorisvandenbossche Would you have time to review and/or merge? |
4df1118
to
88e65b4
Compare
88e65b4
to
8e2b6bd
Compare
Had this sitting around, but would still like to get this done. Just rebased, @jorisvandenbossche would you mind reviewing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay @wjones127 . This looks good to me, but can you rebase to ensure it works with latest git master?
874ce8c
to
dac1264
Compare
If these functions were passed None as an argument, they caused segfaults.
dac1264
to
0f59775
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for persisting with this Will!
Thank you for merging @lidavidm ! |
Benchmark runs are scheduled for baseline = 861f237 and contender = 03e80dc. 03e80dc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
If these functions were passed None as an argument, they caused segfaults. As an example: