ARROW-11431: [Rust][DataFusion] Support the HAVING clause. #9364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
reviewed
Jan 29, 2021
Dandandan
reviewed
Jan 29, 2021
|
This is looking good @drusso ! I think it can use some tests with example (tabular) input as well? To make sure the results are as expected. There are some more end to end tests in the tests directory. |
|
Thanks! I will definitely add some more tests. There are also a couple of clippy errors for me to address. |
alamb
reviewed
Jan 31, 2021
|
@alamb @Dandandan I've updated the PR, let me know if there's anything outstanding. |
jorgecarleitao
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
I went through this PR carefully, understood all the changes and have no comments. Great work, @drusso 💯
I think that we should add it to the README as part of the SQL features. :)
|
I plan to review this carefully tomorrow |
|
Thanks @jorgecarleitao and @alamb! I added a note in the README. |
|
Thanks @drusso ! |
alamb
approved these changes
Feb 3, 2021
|
I am just waiting for the CI to finish on this PR and then I plan to merge it! |
|
Looks like github is operating in degraded fashion: https://www.githubstatus.com/ |
|
All the rust tests are passing. Merging this in even though Travis is still running. |
|
🎉 |
|
🎉 |
|
🚀 |
nevi-me
pushed a commit
to nevi-me/arrow
that referenced
this pull request
Feb 13, 2021
This commit adds support for the SQL `HAVING` clause.
For example, the following queries are supported:
* Filtering on an aggregate:
```
SELECT c1, MAX(c2) FROM t GROUP BY c1 HAVING MAX(c2) > 100;
```
* Filtering on an aliased aggregate:
```
SELECT c1, MAX(c2) AS m FROM t GROUP BY c1 HAVING m > 100;
```
* Filtering on an aggregate that does not appear in the SELECT:
```
SELECT c1, MAX(c2) FROM t GROUP BY c1 HAVING MIN(c2) > 100;
```
* Filtering on a complex aggregates:
```
SELECT c1, MAX(c2) FROM t GROUP BY c1 HAVING MAX(c2 / 2) + 1 > 100;
```
* Filtering on a non-aggregate column:
```
SELECT c1, MAX(c2) FROM t GROUP BY c1 HAVING c1 > 100;
```
* Filtering without a `GROUP BY`:
```
SELECT MAX(c1) FROM t HAVING MAX(c1) > 100;
```
Closes apache#9364 from drusso/ARROW-11431
Authored-by: Daniel Russo <danrusso@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
This commit adds support for the SQL `HAVING` clause.
For example, the following queries are supported:
* Filtering on an aggregate:
```
SELECT c1, MAX(c2) FROM t GROUP BY c1 HAVING MAX(c2) > 100;
```
* Filtering on an aliased aggregate:
```
SELECT c1, MAX(c2) AS m FROM t GROUP BY c1 HAVING m > 100;
```
* Filtering on an aggregate that does not appear in the SELECT:
```
SELECT c1, MAX(c2) FROM t GROUP BY c1 HAVING MIN(c2) > 100;
```
* Filtering on a complex aggregates:
```
SELECT c1, MAX(c2) FROM t GROUP BY c1 HAVING MAX(c2 / 2) + 1 > 100;
```
* Filtering on a non-aggregate column:
```
SELECT c1, MAX(c2) FROM t GROUP BY c1 HAVING c1 > 100;
```
* Filtering without a `GROUP BY`:
```
SELECT MAX(c1) FROM t HAVING MAX(c1) > 100;
```
Closes apache#9364 from drusso/ARROW-11431
Authored-by: Daniel Russo <danrusso@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
This commit adds support for the SQL `HAVING` clause.
For example, the following queries are supported:
* Filtering on an aggregate:
```
SELECT c1, MAX(c2) FROM t GROUP BY c1 HAVING MAX(c2) > 100;
```
* Filtering on an aliased aggregate:
```
SELECT c1, MAX(c2) AS m FROM t GROUP BY c1 HAVING m > 100;
```
* Filtering on an aggregate that does not appear in the SELECT:
```
SELECT c1, MAX(c2) FROM t GROUP BY c1 HAVING MIN(c2) > 100;
```
* Filtering on a complex aggregates:
```
SELECT c1, MAX(c2) FROM t GROUP BY c1 HAVING MAX(c2 / 2) + 1 > 100;
```
* Filtering on a non-aggregate column:
```
SELECT c1, MAX(c2) FROM t GROUP BY c1 HAVING c1 > 100;
```
* Filtering without a `GROUP BY`:
```
SELECT MAX(c1) FROM t HAVING MAX(c1) > 100;
```
Closes apache#9364 from drusso/ARROW-11431
Authored-by: Daniel Russo <danrusso@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the SQL
HAVINGclause.For example, the following queries are supported:
Filtering on an aggregate:
Filtering on an aliased aggregate:
Filtering on an aggregate that does not appear in the SELECT:
Filtering on a complex aggregates:
Filtering on a non-aggregate column:
Filtering without a
GROUP BY: