ARROW-10520: [C++][R] Implement add/remove/replace for RecordBatch #9365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Feb 1, 2021
cpp/src/arrow/record_batch.cc
Outdated
| ARROW_CHECK(column != nullptr); | ||
|
|
||
| if (!field->type()->Equals(column->type())) { | ||
| return Status::Invalid("Column data type ", field->type()->name(), |
There was a problem hiding this comment.
Sure. This is just copied from L92 above; should I change that one too?
There was a problem hiding this comment.
Ah, that would be good. You may need to fix some tests too :-)
There was a problem hiding this comment.
I changed 3 in this file, PTAL
nealrichardson
force-pushed
the
record-batch-add-column
branch
from
e6e3509
to
a809ae3
Compare
pitrou
approved these changes
Feb 1, 2021
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
In C++, RecordBatch had AddColumn and RemoveColumn but no SetColumn; Table had all three. This adds the missing RecordBatch method and adds R bindings. Closes apache#9365 from nealrichardson/record-batch-add-column Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
In C++, RecordBatch had AddColumn and RemoveColumn but no SetColumn; Table had all three. This adds the missing RecordBatch method and adds R bindings. Closes apache#9365 from nealrichardson/record-batch-add-column Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C++, RecordBatch had AddColumn and RemoveColumn but no SetColumn; Table had all three. This adds the missing RecordBatch method and adds R bindings.