ARROW-11686: [C++] Call ArrowLog::InstallFailureSignalHandler to show stack trace #9524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrkn This doesn't seem to compile (see failed CI build). Can you take a look? |
|
Oops! I'm sorry I thought I checked it but I couldn't do that due to the wrong cmake configuration. I'il fix it. |
|
@pitrou The compiling issue was resolved. |
|
Note that it only seems to change something if GLog is enabled? |
|
Yes, it does. InstallFailureSignalHandler and UninstallSingalAction are empty functions if Glog is disabled. |
lidavidm
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
LGTM, thanks.
FWIW, the log from that commit does say:
Invalid: Expected UNAUTHENTICATED but got Unavailable
and the client does call ABORT_NOT_OK so SIGABRT is expected, no? I think in this case, the Rust integration server either crashed or was not ready and listening in time for the client.
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
… stack trace Closes apache#9524 from mrkn/ARROW-11686 Authored-by: Kenta Murata <mrkn@mrkn.jp> Signed-off-by: David Li <li.davidm96@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
… stack trace Closes apache#9524 from mrkn/ARROW-11686 Authored-by: Kenta Murata <mrkn@mrkn.jp> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.