ARROW-11820: [Rust] Added macro to create native types #9597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
elferherrera
changed the title
paddyhoran
approved these changes
Mar 5, 2021
alamb
approved these changes
Mar 13, 2021
There was a problem hiding this comment.
Looks good to me as well -- thanks @elferherrera
It also has the nice benefit that now the rust native type -> Arrow datatype mapping are clearer (e.g. i64 --> Int64, Date64, Time64, Timestamp)
| data_type == &DataType::UInt32 | ||
| } | ||
| macro_rules! create_native { | ||
| ($native_ty:ty,$($impl_pattern:pat)|+) => { |
|
Sorry that I didn't see this one previously |
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
This adds a macro called creative_native to avoid DRY in the creation of native types for alloc module Closes apache#9597 from elferherrera/dry-natives Authored-by: Fernando Herrera <fernando.elizalde@revolut.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
This adds a macro called creative_native to avoid DRY in the creation of native types for alloc module Closes apache#9597 from elferherrera/dry-natives Authored-by: Fernando Herrera <fernando.elizalde@revolut.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a macro called creative_native to avoid DRY in the creation of native types for alloc module