ARROW-11839: [C++] Use xsimd for generation of accelerated bit-unpacking #9614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this is currently blocked by xsimd issues xtensor-stack/xsimd#421 and xtensor-stack/xsimd#422. |
|
@jianxind @cyb70289 Feel free to take a look. It would be interesting to get performance numbers on Neon (one affected benchmark should be |
pitrou
force-pushed
the
ARROW-11839-xsimd-bpacking
branch
from
3ec021f
to
ad11400
Compare
|
I tested Neon performance of Compiler does good optimization for |
|
Interesting, thank you. |
pitrou
force-pushed
the
ARROW-11839-xsimd-bpacking
branch
2 times, most recently
from
c442ff6
to
74b577f
Compare
|
Is there anything left to do here (other than perhaps rebase and hope CI is fixed)? |
The custom per-ISA code generation scripts (AVX2, AVX512) are replaced with a single code generation script that outputs xsimd code for any SIMD bit-width, in an ISA-agnostic way. Also add a Neon optimized version of bit-unpacking that leverages the generated code for 128-bit SIMD.
pitrou
force-pushed
the
ARROW-11839-xsimd-bpacking
branch
from
74b577f
to
57e0857
Compare
|
@nealrichardson We must make sure that compilation works on all C++ builds. |
|
Will merge now. |
Dandandan
pushed a commit
to Dandandan/arrow
that referenced
this pull request
Apr 14, 2021
The custom per-ISA code generation scripts (AVX2, AVX512) are replaced with a single code generation script that outputs xsimd code for any SIMD bit-width, in an ISA-agnostic way. Also add a Neon optimized version of bit-unpacking that leverages the generated code for 128-bit SIMD. Closes apache#9614 from pitrou/ARROW-11839-xsimd-bpacking Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
The custom per-ISA code generation scripts (AVX2, AVX512) are replaced with a single code generation script that outputs xsimd code for any SIMD bit-width, in an ISA-agnostic way. Also add a Neon optimized version of bit-unpacking that leverages the generated code for 128-bit SIMD. Closes apache#9614 from pitrou/ARROW-11839-xsimd-bpacking Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 10, 2021
The custom per-ISA code generation scripts (AVX2, AVX512) are replaced with a single code generation script that outputs xsimd code for any SIMD bit-width, in an ISA-agnostic way. Also add a Neon optimized version of bit-unpacking that leverages the generated code for 128-bit SIMD. Closes apache#9614 from pitrou/ARROW-11839-xsimd-bpacking Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
The custom per-ISA code generation scripts (AVX2, AVX512) are replaced with a single code generation script that outputs xsimd code for any SIMD bit-width, in an ISA-agnostic way. Also add a Neon optimized version of bit-unpacking that leverages the generated code for 128-bit SIMD. Closes apache#9614 from pitrou/ARROW-11839-xsimd-bpacking Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom per-ISA code generation scripts (AVX2, AVX512) are replaced with a single code generation script that outputs xsimd code for any SIMD bit-width, in an ISA-agnostic way.
Also add a Neon optimized version of bit-unpacking that leverages the generated code for 128-bit SIMD.