New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-11896: [Rust] Disable Debug symbols on CI test builds #9653
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9653 +/- ##
==========================================
- Coverage 82.51% 82.50% -0.02%
==========================================
Files 245 245
Lines 57329 57347 +18
==========================================
+ Hits 47306 47312 +6
- Misses 10023 10035 +12
Continue to review full report at Codecov.
|
@alamb this seems to have worked. I'm triggering the jobs to run again, if it passes again; it's a 👍 from me. We've already observed from our local repro attempts that there wasn't any specific PR that caused the issue. It could be that some dependency updates suddenly caused us to hit the memory limits on CI, as you're exploring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thinking and cool idea. 🚢
Curious, when the CI fails, we will no longer have the trace, right? Isn't that a concern whenever we want to share logs e.g. on PRs, mailing lists, etc? |
A compromise could be to disable debug symbols only on the Debian Rust stable runs, as the other platforms seem fine. |
I think this is a likely theory but I don't have any specific data to prove one way or the other
I think we will still get backtraces even without "debug" symbols (the debug symbols are used by gdb / lldb to be able to interpret core dumps / map local variables to memory locations, etc). To confirm this theory I ran the following (on my mac, will try on linux shortly) and the trace is still present
Yeah -- in fact this PR doesn't set the debug flags for Windows or Mac (I believe the Mac builders are larger -- 15GB of memory on github, and windows debugging symbols work significantly different) |
I plan to run this on a linux machine (to confirm the backtrace behavior and then merge it in) |
I still get backtraces on my linux machine (Ubuntu 20.04). ! |
The theory is that the inclusion of debug symbols is increasing the memory requirements of compiling the test binaries which is causing the tests to hit the CI builder's memory limits (and being OOM killed). Changes: Since the debug symbols aren't used for tests, run the CI tests without them to save memory In theory this might also make the builds faster as well @nevi-me and I theorize (without proof) that some new release of a dependency pushed the memory usage over the github builder limit which is why we started seeing this all of a sudden on master without any obvious corresponding code change Closes apache#9653 from alamb/alamb/test_no_debug_symbols Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
The theory is that the inclusion of debug symbols is increasing the memory requirements of compiling the test binaries which is causing the tests to hit the CI builder's memory limits (and being OOM killed). Changes: Since the debug symbols aren't used for tests, run the CI tests without them to save memory In theory this might also make the builds faster as well @nevi-me and I theorize (without proof) that some new release of a dependency pushed the memory usage over the github builder limit which is why we started seeing this all of a sudden on master without any obvious corresponding code change Closes apache#9653 from alamb/alamb/test_no_debug_symbols Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
The theory is that the inclusion of debug symbols is increasing the memory requirements of compiling the test binaries which is causing the tests to hit the CI builder's memory limits (and being OOM killed).
Changes:
Since the debug symbols aren't used for tests, run the CI tests without them to save memory
In theory this might also make the builds faster as well
@nevi-me and I theorize (without proof) that some new release of a dependency pushed the memory usage over the github builder limit which is why we started seeing this all of a sudden on master without any obvious corresponding code change