New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-11700: [R] Internationalize error handling in tidy eval #9717
Conversation
.data$filtered_rows <- new_filter | ||
} else { | ||
.data$filtered_rows <- .data$filtered_rows & new_filter | ||
if (length(expressions)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @ianmcook this is the fix for ARROW-11785
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. This makes perfect sense in my opinion. My computer is in "en_US:en", but I'm used to á é í ó ú ñ, and how i18n is used here provides a standard that looks very stable.
Also fixes ARROW-11785 along the way. Closes apache#9717 from nealrichardson/i18n Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Also fixes ARROW-11785 along the way. Closes apache#9717 from nealrichardson/i18n Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Also fixes ARROW-11785 along the way.