Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-12065: [C++][Python] Fix segfault reading JSON file #9783

Closed
wants to merge 1 commit into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Mar 23, 2021

A segfault would occur when a field is inferred as null in a first block and then as list in a second block.

Also re-enable chunked_builder_test.cc, which wasn't compiled.

@pitrou pitrou requested a review from bkietz March 23, 2021 17:22
A segfault would occur when a field is inferred as null in a first block
and then as list in a second block.

Also re-enable chunked_builder_test.cc, which wasn't compiled.
Copy link
Member

@bkietz bkietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

@pitrou pitrou closed this in 43caa2a Mar 24, 2021
@pitrou pitrou deleted the ARROW-12065-json-segfault branch March 24, 2021 12:25
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
A segfault would occur when a field is inferred as null in a first block and then as list in a second block.

Also re-enable `chunked_builder_test.cc`, which wasn't compiled.

Closes apache#9783 from pitrou/ARROW-12065-json-segfault

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 10, 2021
A segfault would occur when a field is inferred as null in a first block and then as list in a second block.

Also re-enable `chunked_builder_test.cc`, which wasn't compiled.

Closes apache#9783 from pitrou/ARROW-12065-json-segfault

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
A segfault would occur when a field is inferred as null in a first block and then as list in a second block.

Also re-enable `chunked_builder_test.cc`, which wasn't compiled.

Closes apache#9783 from pitrou/ARROW-12065-json-segfault

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants