Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-11993: [C++] Don't download xsimd if ARROW_SIMD_LEVEL=NONE #9807

Closed
wants to merge 1 commit into from
Closed

ARROW-11993: [C++] Don't download xsimd if ARROW_SIMD_LEVEL=NONE #9807

wants to merge 1 commit into from

Conversation

cyb70289
Copy link
Contributor

No description provided.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-11993

kou
kou approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou closed this in 6fe6c02 Mar 26, 2021
@cyb70289 cyb70289 deleted the xsimd branch March 27, 2021 01:53
@kou
Copy link
Member

kou commented Mar 29, 2021

Sorry. It seems that this breaks conda-linux-gcc-py36-aarch64 build:

https://cloud.drone.io/ursacomputing/crossbow/330/1/2

1453../src/arrow/util/utf8.h:27:10: fatal error: xsimd/xsimd.hpp: No such file or directory
1646s
1454 #include <xsimd/xsimd.hpp>
1646s
1455          ^~~~~~~~~~~~~~~~~

It seems that we also need ARROW_SIMD_LEVEL check for armv8 build: https://github.com/apache/arrow/blob/master/cpp/cmake_modules/SetupCxxFlags.cmake#L445-L468

@cyb70289
Copy link
Contributor Author

Ouch, will fix.

@cyb70289 cyb70289 mentioned this pull request Mar 29, 2021
Closed
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
@cyb70289 @GeorgeAp
ARROW-11993: [C++] Don't download xsimd if ARROW_SIMD_LEVEL=NONE
6c30e31 
Closes apache#9807 from cyb70289/xsimd

Authored-by: Yibo Cai <yibo.cai@arm.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 10, 2021
@cyb70289 @michalursa
ARROW-11993: [C++] Don't download xsimd if ARROW_SIMD_LEVEL=NONE
9387672 
Closes apache#9807 from cyb70289/xsimd

Authored-by: Yibo Cai <yibo.cai@arm.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
@cyb70289 @michalursa
ARROW-11993: [C++] Don't download xsimd if ARROW_SIMD_LEVEL=NONE
fa68874 
Closes apache#9807 from cyb70289/xsimd

Authored-by: Yibo Cai <yibo.cai@arm.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This was referenced Apr 14, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cyb70289 @kou