Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-12194: [Rust][Parquet] Bump zstd to v0.7 #9881

Closed
wants to merge 1 commit into from

Conversation

aldanor
Copy link
Contributor

@aldanor aldanor commented Apr 3, 2021

This updates zstd version used by parquet crate to zstd = "0.7.0+zstd.1.4.9".

@github-actions
Copy link

github-actions bot commented Apr 3, 2021

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@codecov-io
Copy link

Codecov Report

Merging #9881 (f157708) into master (5bfae36) will increase coverage by 0.07%.
The diff coverage is 90.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9881      +/-   ##
==========================================
+ Coverage   82.60%   82.68%   +0.07%     
==========================================
  Files         255      256       +1     
  Lines       59674    60105     +431     
==========================================
+ Hits        49295    49699     +404     
- Misses      10379    10406      +27     
Impacted Files Coverage Δ
rust/arrow-pyarrow-integration-testing/src/lib.rs 0.00% <ø> (ø)
rust/arrow/src/datatypes/field.rs 55.47% <0.00%> (ø)
rust/arrow/src/error.rs 11.11% <0.00%> (-0.52%) ⬇️
rust/arrow/src/ipc/writer.rs 86.70% <0.00%> (-0.74%) ⬇️
rust/datafusion/src/logical_plan/expr.rs 83.39% <ø> (ø)
rust/parquet/benches/arrow_writer.rs 0.00% <0.00%> (ø)
rust/datafusion/src/scalar.rs 51.22% <33.33%> (-0.15%) ⬇️
.../datafusion/src/physical_plan/regex_expressions.rs 86.15% <60.00%> (-2.18%) ⬇️
rust/arrow/src/array/ffi.rs 85.13% <83.33%> (-4.23%) ⬇️
rust/datafusion/src/catalog/information_schema.rs 88.78% <89.40%> (+4.05%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d87a0e...f157708. Read the comment docs.

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aldanor ! I took the liberty of rebasing this PR against apache master to pick up #9879? I think that should fix the CI failures on this PR

Once we get a clean run I'll mege it in

@aldanor
Copy link
Contributor Author

aldanor commented Apr 3, 2021

@alamb 👍

@alamb alamb changed the title [Rust][Parquet] Bump zstd to v0.7 ARROW-12194: [Rust][Parquet] Bump zstd to v0.7 Apr 4, 2021
@alamb alamb closed this in ebe4295 Apr 4, 2021
@github-actions
Copy link

github-actions bot commented Apr 4, 2021

@alamb
Copy link
Contributor

alamb commented Apr 4, 2021

Thanks again @aldanor !

ritchie46 pushed a commit to ritchie46/arrow that referenced this pull request Apr 5, 2021
This updates zstd version used by parquet crate to zstd = "0.7.0+zstd.1.4.9".

Closes apache#9881 from aldanor/feature/zstd-0.7

Authored-by: Ivan Smirnov <i.s.smirnov@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
pachadotdev pushed a commit to pachadotdev/arrow that referenced this pull request Apr 5, 2021
This updates zstd version used by parquet crate to zstd = "0.7.0+zstd.1.4.9".

Closes apache#9881 from aldanor/feature/zstd-0.7

Authored-by: Ivan Smirnov <i.s.smirnov@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
This updates zstd version used by parquet crate to zstd = "0.7.0+zstd.1.4.9".

Closes apache#9881 from aldanor/feature/zstd-0.7

Authored-by: Ivan Smirnov <i.s.smirnov@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 10, 2021
This updates zstd version used by parquet crate to zstd = "0.7.0+zstd.1.4.9".

Closes apache#9881 from aldanor/feature/zstd-0.7

Authored-by: Ivan Smirnov <i.s.smirnov@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
This updates zstd version used by parquet crate to zstd = "0.7.0+zstd.1.4.9".

Closes apache#9881 from aldanor/feature/zstd-0.7

Authored-by: Ivan Smirnov <i.s.smirnov@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants