ARROW-12248: [C++] Avoid looking up ARROW_DEFAULT_MEMORY_POOL environment variable too late #9930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment variable too late In some situations (e.g. R bindings), default_memory_pool() may be called before the Arrow library's global variables were fully initialized.
|
This looks good to me, I tested it locally and in at least the situation I was building (static r package build) I can now change allocators. Thanks! |
lidavidm
approved these changes
Apr 13, 2021
Dandandan
pushed a commit
to Dandandan/arrow
that referenced
this pull request
Apr 14, 2021
…ment variable too late In some situations (e.g. R bindings), default_memory_pool() may be called before the Arrow library's global variables were fully initialized. Closes apache#9930 from pitrou/ARROW-12248-memory-pool-env-lookup Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: David Li <li.davidm96@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…ment variable too late In some situations (e.g. R bindings), default_memory_pool() may be called before the Arrow library's global variables were fully initialized. Closes apache#9930 from pitrou/ARROW-12248-memory-pool-env-lookup Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: David Li <li.davidm96@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 10, 2021
…ment variable too late In some situations (e.g. R bindings), default_memory_pool() may be called before the Arrow library's global variables were fully initialized. Closes apache#9930 from pitrou/ARROW-12248-memory-pool-env-lookup Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: David Li <li.davidm96@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…ment variable too late In some situations (e.g. R bindings), default_memory_pool() may be called before the Arrow library's global variables were fully initialized. Closes apache#9930 from pitrou/ARROW-12248-memory-pool-env-lookup Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations (e.g. R bindings), default_memory_pool() may be called before the Arrow library's global variables were fully initialized.