ARROW-12326: [C++] Avoid needless c-ares detection #9977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use system gRPC, we don't need to detect c-ares. This change also simplifies gRPC detection. System gRPC detection requires CMake config or pkg-config. System gRPC detection by gRPC_ROOT is removed because we can't maintain Abseil dependencies.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@github-actions crossbow submit -g nightly |
|
Revision: 056a87a Submitted crossbow builds: ursacomputing/crossbow @ actions-308
|
|
This works now. |
ianmcook
reviewed
Apr 12, 2021
| set(GRPCPP_COMPILE_OPTIONS ${GRPCPP_PC_CFLAGS_OTHER}) | ||
| else() | ||
| set(GRPCPP_LINK_LIBRARIES) | ||
| foreach(GRPCPP_LIBRARY_NAME ${GRPCPP_PC_STATIC_LIBRARIES}) |
There was a problem hiding this comment.
Should there be an assertion here to check that the required libraries are in GRPCPP_PC_STATIC_LIBRARIES before iterating over them?
There was a problem hiding this comment.
I don't think that we need it.
Because we already check GRPCC_PC_FOUND. We can assume that pkg_check_modules() sets GRPCPP_PC_* and GRPCPP_PC_STATIC_* variables.
(I don't think that it can be occurred but) If GRPCPP_PC_STATIC_LIBRARIES is empty, the following list(GET GRPCPP_LINK_LIBRARIES 0 GRPCPP_IMPORTED_LOCATION) is failed. So we can detect invalid value eventually.
ianmcook
reviewed
Apr 12, 2021
| "${GRPC_INCLUDE_DIR}") | ||
| "${GRPCPP_INCLUDE_DIRECTORIES}" | ||
| INTERFACE_LINK_LIBRARIES | ||
| "${GRPCPP_LINK_LIBRARIES}" |
There was a problem hiding this comment.
Could GRPCPP_LINK_LIBRARIES contain extraneous libraries that might cause problems here?
There was a problem hiding this comment.
If grpc++.pc is broken, it can be occurred. But it's a grpc++.pc problem. We should fix grpc++.pc instead of our .cmake.
Dandandan
pushed a commit
to Dandandan/arrow
that referenced
this pull request
Apr 14, 2021
If we use system gRPC, we don't need to detect c-ares. This change also simplifies gRPC detection. System gRPC detection requires CMake config or pkg-config. System gRPC detection by gRPC_ROOT is removed because we can't maintain Abseil dependencies. Closes apache#9977 from kou/cpp-avoid-needless-c-ares-detection Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
If we use system gRPC, we don't need to detect c-ares. This change also simplifies gRPC detection. System gRPC detection requires CMake config or pkg-config. System gRPC detection by gRPC_ROOT is removed because we can't maintain Abseil dependencies. Closes apache#9977 from kou/cpp-avoid-needless-c-ares-detection Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 10, 2021
If we use system gRPC, we don't need to detect c-ares. This change also simplifies gRPC detection. System gRPC detection requires CMake config or pkg-config. System gRPC detection by gRPC_ROOT is removed because we can't maintain Abseil dependencies. Closes apache#9977 from kou/cpp-avoid-needless-c-ares-detection Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
If we use system gRPC, we don't need to detect c-ares. This change also simplifies gRPC detection. System gRPC detection requires CMake config or pkg-config. System gRPC detection by gRPC_ROOT is removed because we can't maintain Abseil dependencies. Closes apache#9977 from kou/cpp-avoid-needless-c-ares-detection Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use system gRPC, we don't need to detect c-ares.
This change also simplifies gRPC detection. System gRPC detection
requires CMake config or pkg-config. System gRPC detection by
gRPC_ROOT is removed because we can't maintain Abseil dependencies.