Remove os.path.join causing incorrect windows path #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevalbhatt @pinal-shah @mandarambawane @mneethiraj Any activity on the Python Client? |
|
@bdsoha - thank you for the fix. Changes look good. I created ATLAS-4704 to track this fix. The fix will be merged shortly. |
|
@mneethiraj Any chance a new release will published soon? The latest version of the client |
|
@bdsoha - Apache Atlas Python client 0.0.12 was released today. |
|
@mneethiraj Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on Windows the
os.path.joinusing the operating systemsos.sep=\which causing the full url to be incorrect.Using
urllib.parsemight be a little bit slower, but is less error-prone.