ATLAS-3001: Fixed AtlasClientV2.updateClassifications() to not expect a return body #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look good. |
|
Could you open a review item? I will take care of committing these changes. |
paul-k-civitas
changed the title
|
This issue is already in ATLAS-3001, Thanks @paul-k-civitas for reporting with PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
Right now, the
AtlasClientV2.updateClassifications()method is not functional because it expects a response body that can be deserialized into anAtlasClassificationsinstance, but the response according to the REST API will be empty, with a status code of204 No Content. This change fixes the client so that the response's body will not be de-serialized.