ATLAS-3041 : Fix for Cannot delete relationship types using the /typedef/name REST API

[aadarshjajodia]

…/typedef/name REST API

Since the AtlasRelationshipDef is extending AtlasStructDef, we make an additonal
check in deleteByName before the AtlasStructDef check to see if the instance to be
deleted is of type AtlasRelationshipDef.

[mneethiraj]

@aadarshjajodia - can you look into the following unit-test failure? This is likely caused by the two new types added in this patch - cluster and host. Perhaps deleteTypeByName() should be updated to delete these types as well (along with other types)?

Tests run: 17, Failures: 1, Errors: 0, Skipped: 15, Time elapsed: 48.052 sec <<< FAILURE! - in org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStoreTest

testGet(org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStoreTest) Time elapsed: 0.026 sec <<< FAILURE!
java.lang.AssertionError: expected [0] but found [2]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:372)
at org.testng.Assert.assertEquals(Assert.java:382)
at org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStoreTest.testGet(AtlasTypeDefGraphStoreTest.java:87)

[aadarshjajodia]

@mneethiraj please review. I have updated the pull request.

[mneethiraj]

@aadarshjajodia - the updates look good. Please confirm that UTs pass successfully (mvn clean package).

[aadarshjajodia]

@mneethiraj ran mvn clean package on the atlas home dir. It passed all the tests. Thanks.