Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AXIS2-6049 static serialVersionUID for Exception #384

Closed
wants to merge 2 commits into from

Conversation

yoadey
Copy link

@yoadey yoadey commented Nov 8, 2022

serialVersionUID would change every generation and won't be useful then. Also not needed for SOAP. Use static 1L as serialVersionUID for Exception. This also allows build caches to be used.

serialVersionUID would change every generation and won't be useful then. Also not needed for SOAP. Use static 1L as serialVersionUID for Exception.
@veithen
Copy link
Member

veithen commented Nov 8, 2022

Looks like there is a problem with this change because tests are failing.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2022

Codecov Report

Merging #384 (02669a3) into master (ecfe305) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   42.56%   42.57%           
=======================================
  Files        1500     1500           
  Lines      115008   115011    +3     
  Branches    22586    22587    +1     
=======================================
+ Hits        48958    48968   +10     
+ Misses      58290    58284    -6     
+ Partials     7760     7759    -1     
Impacted Files Coverage Δ
.../emitter/AxisServiceBasedMultiLanguageEmitter.java 54.70% <100.00%> (ø)
...apache/axis2/kernel/http/SOAPMessageFormatter.java 84.76% <0.00%> (+0.44%) ⬆️
...rnel/src/org/apache/axis2/builder/BuilderUtil.java 49.60% <0.00%> (+1.18%) ⬆️
...n/java/org/apache/axis2/webapp/CSRFTokenCache.java 100.00% <0.00%> (+44.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yoadey
Copy link
Author

yoadey commented Nov 29, 2022

@veithen could you take a look at this PR whether it's ok and merge it if nothing is preventing it? Would help us a lot to improve build time and make more reproducable builds

@veithen veithen closed this in 9bab9c4 Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants