Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

[BAHIR-91] Upgrade Flink version to 1.2.0 #11

Closed
wants to merge 2 commits into from

Conversation

tzulitai
Copy link
Contributor

@tzulitai tzulitai commented Mar 1, 2017

This required some Flink state API updates in the tests. We probably should keep an extra eye on these kind of Flink API changes; the source APIs may be stable, but API changes like these can also break code in bahir-flink. (I suggest a new major version for bahir-flink every time a API break happens from Flink, and as soon as that happens for the first time from now on, we start maintaining a compatibility matrix for bahir-flink).

Note about the additional maven-bundle-plugin in the Redis connector:
After the 1.2.0 upgrade, the project had a new dependency to Apacheds JDBM 2.0.0-M2, which packages using the "bundle" type. The plugin helps recognizes the type when building.

pom.xml Outdated
@@ -90,7 +90,7 @@
<log4j.version>1.2.17</log4j.version>

<!-- Spark version -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor note: I changed this line to Flink version in #10, so not changing it in this PR to avoid conflicts.

@rmetzger
Copy link
Contributor

rmetzger commented Mar 1, 2017

I think the travis tests will fail because they are overwriting the Flink version.
I have a constant there for the Flink version. My initial plan was to support multiple Flink versions at the same time.
Do you think there is an easy way to still support 1.1. and 1.2 with the Bahir connectors?

@tzulitai
Copy link
Contributor Author

tzulitai commented Mar 1, 2017

@rmetzger I don't think there's an easy way to do this, unless we try to make the affected connectors backwards compatible.

Just rebased on master to resolve conflicts.

@rmetzger
Copy link
Contributor

rmetzger commented Mar 2, 2017

The travis build failed, probably because of the version override from the travis.yml.

@tzulitai
Copy link
Contributor Author

tzulitai commented Mar 2, 2017

Ah yes, I forgot about that. I'll change that to 1.2.0.

@rmetzger
Copy link
Contributor

rmetzger commented Mar 4, 2017

Looks good. Merging change.

@asfgit asfgit closed this in 3f18034 Mar 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants