Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

[BAHIR-173]Update Flink version to 1.5.1 #29

Closed
wants to merge 3 commits into from

Conversation

Wosin
Copy link
Contributor

@Wosin Wosin commented Jul 20, 2018

This PR updates the version of Flink to the last official release 1.5.1.
This update required updating akka version in flink-connector-akka module.
MultiException was removed since it was imported directly from Flink and is not present in Flink 1.5.1.

.travis.yml Outdated
- CACHE_NAME=JDK8_F130_A
- jdk: oraclejdk8
env:
- FLINK_VERSION="1.3.0" SCALA_VERSION="2.10"
- FLINK_VERSION="1.5.1" SCALA_VERSION="2.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the version on scala 2.10 was deprecated on flink version 1.4.0
you have to remove this test

.travis.yml Outdated
- CACHE_NAME=JDK8_F130_B
- jdk: openjdk8
env:
- FLINK_VERSION="1.3.0" SCALA_VERSION="2.11"
- FLINK_VERSION="1.5.1" SCALA_VERSION="2.11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the version on scala 2.10 was deprecated on flink version 1.4.0
you have to remove this test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know:) I am switching this to scala 2.12

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If scala 2.10 is deprecated, I would remove them from the travis profiles (as they are the ones failing) and would submit support for 2.12 as a new PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this seems reasonable. I will remove them completely then.

@lresende
Copy link
Member

LGTM, any other comments?

@asfgit asfgit closed this in 567792b Jul 26, 2018
@lresende
Copy link
Member

@eskabetxe do you have a jira account so that I can assign the jira to yourself?

@eskabetxe
Copy link
Member

yes same user

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants