Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Travis CI YAML config #28

Closed
wants to merge 2 commits into from
Closed

Adding Travis CI YAML config #28

wants to merge 2 commits into from

Conversation

chimerasaurus
Copy link

Re-adding YAML config for Travis CI (sorry - had to fix a GitHub mess I accidentally created here.) This replaces PR #24.

@dhalperi
Copy link

Glad the PR found that JB's website is down.. shows the checks are working.

Is there a way to whitelist that particular failure?

@chimerasaurus
Copy link
Author

You mean avoid URL status checking entirely or to have it be non-fatal?

@dhalperi
Copy link

Latter

@chimerasaurus
Copy link
Author

Does not look like it. While that may make some tests flaky, I also posit that it means our live content may have HTTP 4/X 5/X errors, which is probably worth knowing about with a fatal.

@dhalperi
Copy link

@chimerasaurus
Copy link
Author

We can do that, though we'll possibly have to ignore links on a per-link basis or in general.

How about we ignore this one link for the time being and if this becomes a problem, we can mod Jekyll to inject the ignore attribute for all links in one area (like the Blog) or in all areas?

@dhalperi
Copy link

ack

On Wed, Jul 27, 2016 at 12:54 PM, James Malone notifications@github.com
wrote:

We can do that, though we'll possibly have to ignore links on a per-link
basis or in general.

How about we ignore this one link for the time being and if this becomes a
problem, we can mod Jekyll to inject the ignore attribute for all links in
one area (like the Blog) or in all areas?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#28 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgITwfmfo_1paauY4OP1b7z8CdU6o8Dks5qZ7d0gaJpZM4JUU0H
.

@chimerasaurus
Copy link
Author

New commit (550be51) with minor update to ignore link added. If it looks good, I can squash them and merge.

@asfgit asfgit closed this in a64faf2 Jul 29, 2016
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants