Add 2017 look back blog post #370
Conversation
There was a problem hiding this comment.
Content LGTM, minus the image as you already mention. as a heads up this may run into the mergebot issue that happens when adding a new page (see https://issues.apache.org/jira/browse/BEAM-3266) so the jekyll generated html file and image may also need to be added manually to the content directory. (like had to be done in #306 )
| ![Grid computer and numerical simulations, batch ETL and ML pre-processing, | ||
| streaming ETL, IoT and real-time anomaly detection, real-time mobile game | ||
| session personalization]( | ||
| {{ "/images/beam_versatility_use_cases.svg" | prepend: site.baseurl }}) |
There was a problem hiding this comment.
I only just now notice that there's a blog directory inside images, I guess the image should go somewhere in there.
|
Just updated the PR to include image. Ready for a review ;) |
| of diverse use cases. Here are some use cases that exemplify the versatility of | ||
| Beam. | ||
|
|
||
| <img class="center-block" |
There was a problem hiding this comment.
the jenkins verification job is failing due to image needing alt text:
image /images/blog/2017-look-back/timeline.png does not have an alt attribute (line 110)
I also think the image might need to be cropped to remove extra blank space around the graphic? from looking at staged version, there's a pretty big empty space below:
http://apache-beam-website-pull-requests.storage.googleapis.com/370/blog/2018/01/09/beam-a-look-back.html
|
I updated the blog post to include |
|
@melap can you take a look please ? Thanks ! |
jbonofre
force-pushed
the
BEAM_LOOK_BACK_BLOG
branch
from
36828af
to
64b8b9d
Compare
|
Rebase/squash done. |
|
@asfgit merge |
NB: This PR is not yet ready to be merged: I have to add the image in the
imagesfolder.However, it's ready for a review in term of content.