-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-4119] Update i/o testing documentation to use gradle #425
[BEAM-4119] Update i/o testing documentation to use gradle #425
Conversation
8b863d9
to
09d7700
Compare
LGTM. Thanks. |
R: @melap can you take another look and merge ? |
retest this please |
Hi there @lgajowy , thanks for the PR! the content/ directory on the website is autogenerated from the files in the src/ directory after a merge, so your changes here would be overwritten. could you please move your changes into the associated file in the src/ directory (src/documentation/io/testing.md) and revert the content/ file? thanks! |
09d7700
to
0d1407a
Compare
@melap done - I guess I should have figured it out earlier. :) Could you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! just one very minor comment/question -- if you could check that out, and if so just fix/rebase and I (or someone else) will merge. thank you! 😄
src/documentation/io/testing.md
Outdated
</td> | ||
</tr> | ||
<tr> | ||
<td>-Dio-it-suite-local | ||
<td>integrationTestPipelineOptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this one have -D like the other options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True - same as logLevel
in line 450. Corrected both.
0d1407a
to
a63a504
Compare
@melap thanks! Corrected and rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@asfgit merge |
Error: PR failed in verification; check the Jenkins job for more information. |
@asfgit merge |
Error: PR failed in verification; check the Jenkins job for more information. |
There's a problem with a link that is unrelated to this PR. I will try to merge again tomorrow. |
@asfgit merge |
Error: PR failed in verification; check the Jenkins job for more information. |
@asfgit merge |
This is to update the io testing documentation with lately added Gradle commands. Due to the fact that there are no profiles in Gradle, some thing had to be done differently, hence some changes in the running instructions too.
CC: @melap @chamikaramj @swegner