Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-4119] Update i/o testing documentation to use gradle #425

Merged

Conversation

lgajowy
Copy link

@lgajowy lgajowy commented Apr 20, 2018

This is to update the io testing documentation with lately added Gradle commands. Due to the fact that there are no profiles in Gradle, some thing had to be done differently, hence some changes in the running instructions too.

CC: @melap @chamikaramj @swegner

@lgajowy lgajowy force-pushed the BEAM-4119_io_testing_documentation_gradle branch from 8b863d9 to 09d7700 Compare April 20, 2018 17:00
@chamikaramj
Copy link

LGTM. Thanks.

@chamikaramj
Copy link

R: @melap can you take another look and merge ?

@melap
Copy link

melap commented Apr 26, 2018

retest this please

@melap
Copy link

melap commented Apr 26, 2018

Hi there @lgajowy , thanks for the PR! the content/ directory on the website is autogenerated from the files in the src/ directory after a merge, so your changes here would be overwritten. could you please move your changes into the associated file in the src/ directory (src/documentation/io/testing.md) and revert the content/ file? thanks!

@lgajowy lgajowy force-pushed the BEAM-4119_io_testing_documentation_gradle branch from 09d7700 to 0d1407a Compare April 26, 2018 10:58
@lgajowy
Copy link
Author

lgajowy commented Apr 26, 2018

@melap done - I guess I should have figured it out earlier. :) Could you take another look?

@melap
Copy link

melap commented Apr 26, 2018

Copy link

@melap melap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! just one very minor comment/question -- if you could check that out, and if so just fix/rebase and I (or someone else) will merge. thank you! 😄

</td>
</tr>
<tr>
<td>-Dio-it-suite-local
<td>integrationTestPipelineOptions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this one have -D like the other options?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True - same as logLevel in line 450. Corrected both.

@lgajowy lgajowy force-pushed the BEAM-4119_io_testing_documentation_gradle branch from 0d1407a to a63a504 Compare April 26, 2018 15:36
@lgajowy
Copy link
Author

lgajowy commented Apr 26, 2018

@melap thanks! Corrected and rebased.

Copy link

@melap melap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@melap
Copy link

melap commented Apr 26, 2018

@asfgit merge

asfgit pushed a commit that referenced this pull request Apr 26, 2018
@asfgit
Copy link

asfgit commented Apr 26, 2018

Error: PR failed in verification; check the Jenkins job for more information.

@melap
Copy link

melap commented Apr 27, 2018

@asfgit merge

asfgit pushed a commit that referenced this pull request Apr 27, 2018
@asfgit
Copy link

asfgit commented Apr 27, 2018

Error: PR failed in verification; check the Jenkins job for more information.

@melap
Copy link

melap commented Apr 27, 2018

There's a problem with a link that is unrelated to this PR. I will try to merge again tomorrow.

@melap
Copy link

melap commented Apr 27, 2018

@asfgit merge

asfgit pushed a commit that referenced this pull request Apr 27, 2018
@asfgit
Copy link

asfgit commented Apr 27, 2018

Error: PR failed in verification; check the Jenkins job for more information.

@melap
Copy link

melap commented Apr 27, 2018

@asfgit merge

asfgit pushed a commit that referenced this pull request Apr 27, 2018
@asfgit asfgit merged commit a63a504 into apache:asf-site Apr 27, 2018
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants