Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDE setup instructions #44

Closed
wants to merge 1 commit into from

Conversation

cschneider
Copy link

See my mail "Documentation for IDE setup" on the dev list for details.

@jbonofre
Copy link
Member

jbonofre commented Oct 14, 2016

R: @jbonofre
CC: @francesperry

@jbonofre
Copy link
Member

Don't you think it could be a section of the contribution guide ? Do you prefer a dedicated section ?

out the code.

## Intellij

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just a quick comment about the code style would be helpful there. I can do that when merging the PR.

-> Eclipse Marketplace
-> Search for "m2 apt"
-> Install m2e-apt 1.2 or higher

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could provide a better rendering there (minor).

@@ -63,6 +63,7 @@
<li role="separator" class="divider"></li>
<li class="dropdown-header">Basics</li>
<li><a href="{{ site.baseurl }}/contribute/contribution-guide/">Contribution Guide</a></li>
<li><a href="{{ site.baseurl }}/contribute/ide-setup/">IDE setup</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about a dedicated section for IDE setup. It could be part of the Contribution Guide. WDYT ?

@francesperry
Copy link
Member

+1 to JB's suggestion of putting it under the one time setup section in the contribution guide.

@cschneider
Copy link
Author

I merged the ide setup into the contribution guide as requested

@jbonofre
Copy link
Member

Thanks, I gonna take a look.

@@ -59,6 +59,47 @@ To contribute code to Apache Beam, you’ll have to do a few administrative step

### One-time Setup

#### Intellij

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about filing a starter JIRA issue to fill this in and linking to that? Helps encourage folks who might know to come back and contribute.

@francesperry
Copy link
Member

Since @jbonofre is out, @cschneider do you want me to merge this?

@cschneider
Copy link
Author

Sure .. that would be great

@francesperry
Copy link
Member

Merging!

@asfgit asfgit closed this in ccc23ff Oct 26, 2016
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants