Add link to @RequiresStableInput design doc #470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aromanenko-dev
requested changes
Jun 15, 2018
| @@ -190,7 +190,7 @@ <h3 id="beam-model">Beam Model</h3> | |||
| <li>Error Reporting Callback (WIP) [<a href="https://docs.google.com/document/d/1o2VXwCL97k3G-1BR9RSKNc6XtJTIA6SEKPMne91S67Y">doc</a>]</li> | |||
| <li>Snapshotting and Updating Beam Pipelines [<a href="https://docs.google.com/document/d/1UWhnYPgui0gUYOsuGcCjLuoOUlGA4QaY91n8p3wz9MY">doc</a>]</li> | |||
| <li>Requiring PTransform to set a coder on its resulting collections [<a href="https://lists.apache.org/thread.html/1dde0b5a93c2983cbab5f68ce7c74580102f5bb2baaa816585d7eabb@%3Cdev.beam.apache.org%3E">mail</a>]</li> | |||
| <li>[PROPOSAL] @RequiresStableInput [<a href="https://docs.google.com/document/d/117yRKbbcEdm3eIKB_26BHOJGmHSZl1YNoF0RqWGtqAM">doc</a>] [<a href="https://lists.apache.org/thread.html/ae3c838df060e47148439d1dad818d5e927b2a25ff00cc4153221dff@%3Cdev.beam.apache.org%3E">mail</a>]</li> | |||
| <li>[PROPOSAL] @RequiresStableInput [<a href="https://docs.google.com/document/d/117yRKbbcEdm3eIKB_26BHOJGmHSZl1YNoF0RqWGtqAM">doc</a>], [<a href="https://lists.apache.org/thread.html/ae3c838df060e47148439d1dad818d5e927b2a25ff00cc4153221dff@%3Cdev.beam.apache.org%3E">mail</a>]</li> | |||
There was a problem hiding this comment.
I believe PR should not contain changes to content directory since merging that is tricky.
Could you run a command git checkout -- content to remove autogenerated content and exclude commit with files from content directory?
There was a problem hiding this comment.
OK I see. Now I know the structure of the repo. Thank you for all the comments!
src/contribute/design-documents.md
Outdated
| To add new design document it is recommended to use this [design document template](https://docs.google.com/document/d/1kVePqjt2daZd0bQHGUwghlcLbhvrny7VpflAzk9sjUg) |
There was a problem hiding this comment.
I don't see any changes here. Is it only padding/eol character or anything else that I missed?
src/contribute/design-documents.md
Outdated
| @@ -40,7 +40,7 @@ This is a collection of documents that may or may not be up to date. | |||
| - Error Reporting Callback (WIP) [[doc](https://docs.google.com/document/d/1o2VXwCL97k3G-1BR9RSKNc6XtJTIA6SEKPMne91S67Y)] | |||
| - Snapshotting and Updating Beam Pipelines [[doc](https://docs.google.com/document/d/1UWhnYPgui0gUYOsuGcCjLuoOUlGA4QaY91n8p3wz9MY)] | |||
| - Requiring PTransform to set a coder on its resulting collections [[mail](https://lists.apache.org/thread.html/1dde0b5a93c2983cbab5f68ce7c74580102f5bb2baaa816585d7eabb@%3Cdev.beam.apache.org%3E)] | |||
| - [PROPOSAL] "Requires deterministic input" [[mail](https://lists.apache.org/thread.html/ae3c838df060e47148439d1dad818d5e927b2a25ff00cc4153221dff@%3Cdev.beam.apache.org%3E)] | |||
| - [PROPOSAL] @RequiresStableInput [[doc](https://docs.google.com/document/d/117yRKbbcEdm3eIKB_26BHOJGmHSZl1YNoF0RqWGtqAM)], [[mail](https://lists.apache.org/thread.html/ae3c838df060e47148439d1dad818d5e927b2a25ff00cc4153221dff@%3Cdev.beam.apache.org%3E)] | |||
There was a problem hiding this comment.
Instead of just name of annotation, I'd add a small text description of this document, for example Support of @RequiresStableInput annotation.
|
retest this please |
|
Retest this please |
|
retest this please |
|
LGTM, thanks |
|
@jasonkuster @swegner can somebody help us take a look what is going ? |
|
retest this please |
|
@asfgit merge |
swegner
pushed a commit
to swegner/beam
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.