Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test baseurl presence and fix breaks #66

Merged
merged 2 commits into from
Nov 5, 2016
Merged

Test baseurl presence and fix breaks #66

merged 2 commits into from
Nov 5, 2016

Conversation

dhalperi
Copy link

@dhalperi dhalperi commented Nov 4, 2016

Two commits:

  1. Add baseurl everywhere it's needed
  2. Add tests that will catch future breaks

The tests use a separate config to set test-specific properties. The site.url configuration specifically does not appear settable from the Jekyll CLI. Unfortunately this means that there is one property shared between config and test (.testcontent)

Also adds content and .testcontent to the excludes list so that the builds of each do not include the other.

@dhalperi
Copy link
Author

dhalperi commented Nov 4, 2016

R: @davorbonaci

@asfbot
Copy link

asfbot commented Nov 4, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Test/19/

@asfbot
Copy link

asfbot commented Nov 4, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/65/

Jenkins built the site at commit id 3828435 with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@asfbot
Copy link

asfbot commented Nov 4, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Test/20/

@asfbot
Copy link

asfbot commented Nov 4, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/66/

Jenkins built the site at commit id dc17e3a with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@asfbot
Copy link

asfbot commented Nov 4, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/68/
--none--

@asfbot
Copy link

asfbot commented Nov 4, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Test/22/

@asfbot
Copy link

asfbot commented Nov 4, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Test/24/

@asfbot
Copy link

asfbot commented Nov 4, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/70/

Jenkins built the site at commit id 106e357 with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@dhalperi dhalperi force-pushed the baseurl branch 2 times, most recently from efc92c8 to e3eb891 Compare November 5, 2016 00:45
@asfbot
Copy link

asfbot commented Nov 5, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Test/25/

@asfbot
Copy link

asfbot commented Nov 5, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Test/26/

@asfbot
Copy link

asfbot commented Nov 5, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/71/

Jenkins built the site at commit id efc92c8 with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@asfgit asfgit merged commit e3eb891 into apache:asf-site Nov 5, 2016
asfgit pushed a commit that referenced this pull request Nov 5, 2016
@davorbonaci
This closes #66
228a6c9
@davorbonaci
Copy link
Member

LGTM. Merged.

@asfbot
Copy link

asfbot commented Nov 5, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/72/

Jenkins built the site at commit id e3eb891 with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@dhalperi dhalperi deleted the baseurl branch November 5, 2016 00:57
jkff added a commit to jkff/beam-site that referenced this pull request Aug 10, 2017
@jkff
A couple of fixes to website
e554407 
* _config_test.yml was supposed to generate into the `.testcontent`
  directory, per the original PR apache#66, but didn't. I fixed this.
* Fixed README.md to not say that `rake test` will regenerate content,
  and rephrased it a bit.
* Added proper `git remote` address for the website in contribution
  guide for committers.
@jkff jkff mentioned this pull request Aug 10, 2017
Closed
asfgit pushed a commit that referenced this pull request Aug 10, 2017
@jkff
A couple of fixes to website
8d1305a 
* _config_test.yml was supposed to generate into the `.testcontent`
  directory, per the original PR #66, but didn't. I fixed this.
* Fixed README.md to not say that `rake test` will regenerate content,
  and rephrased it a bit.
* Added proper `git remote` address for the website in contribution
  guide for committers.
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
@davorbonaci
This closes apache/beam-site#66
0f2ab1f
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
@jkff
A couple of fixes to website
3e78be1 
* _config_test.yml was supposed to generate into the `.testcontent`
  directory, per the original PR apache/beam-site#66, but didn't. I fixed this.
* Fixed README.md to not say that `rake test` will regenerate content,
  and rephrased it a bit.
* Added proper `git remote` address for the website in contribution
  guide for committers.
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
@jkff
A couple of fixes to website
85872a6 
* _config_test.yml was supposed to generate into the `.testcontent`
  directory, per the original PR apache/beam-site#66, but didn't. I fixed this.
* Fixed README.md to not say that `rake test` will regenerate content,
  and rephrased it a bit.
* Added proper `git remote` address for the website in contribution
  guide for committers.
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
@davorbonaci
This closes apache/beam-site#66
6b9741c
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
@jkff
A couple of fixes to website
5034418 
* _config_test.yml was supposed to generate into the `.testcontent`
  directory, per the original PR apache/beam-site#66, but didn't. I fixed this.
* Fixed README.md to not say that `rake test` will regenerate content,
  and rephrased it a bit.
* Added proper `git remote` address for the website in contribution
  guide for committers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dhalperi @asfbot @davorbonaci @asfgit