Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"before" instead of "behind" for "early" elements #82

Merged
merged 1 commit into from
Nov 14, 2016
Merged

"before" instead of "behind" for "early" elements #82

merged 1 commit into from
Nov 14, 2016

Conversation

manuzhang
Copy link

@manuzhang manuzhang commented Nov 14, 2016

R: @tgroh

@asfbot
Copy link

asfbot commented Nov 14, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Test/62/
--none--

@asfbot
Copy link

asfbot commented Nov 14, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/106/

Jenkins built the site at commit id 5411eed with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@tgroh
Copy link
Member

tgroh commented Nov 14, 2016

This LGTM, plus reasoning (mainly written for my sake)

We're answering one of two questions (from Streaming 102): "Where in event time are results calculated?" or "When in processing time are results materialized?"

This describes the arrival of elements with regard to the watermark, which is part of when we materialize results. Given that, it is correct to use temporal rather than spatial words.

@asfgit asfgit merged commit 5411eed into apache:asf-site Nov 14, 2016
asfgit pushed a commit that referenced this pull request Nov 14, 2016
@manuzhang
Copy link
Author

would be great if we can allow comments on blog

robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants