Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small addition and fix #88

Closed
wants to merge 4 commits into from
Closed

Small addition and fix #88

wants to merge 4 commits into from

Conversation

hadarhg
Copy link

@hadarhg hadarhg commented Nov 18, 2016

  • Open Java SDK API Reference in new tab
  • Add external link icon to Java SDK API Reference
  • Fix header in WordCount Walkthrough

@hadarhg
Copy link
Author

hadarhg commented Nov 18, 2016

R: @davorbonaci

@asfbot
Copy link

asfbot commented Nov 18, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Test/92/
--none--

@asfbot
Copy link

asfbot commented Nov 18, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/136/

Jenkins built the site at commit id 85507ac with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

Copy link
Member

@davorbonaci davorbonaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -44,7 +44,10 @@
<li role="separator" class="divider"></li>
<li class="dropdown-header">SDKs</li>
<li><a href="{{ site.baseurl }}/documentation/sdks/java/">Java SDK</a></li>
<li><a href="{{ site.baseurl }}/documentation/sdks/javadoc/">Java SDK API Reference</a></li>
<li><a href="{{ site.baseurl }}/documentation/sdks/javadoc/" target="_blank">Java SDK API Reference <img src="{{ site.baseurl }}/images/external_link.png"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadoc/{{ site.release_latest }}

<li><a href="{{ site.baseurl }}/documentation/sdks/javadoc/">Java SDK API Reference</a></li>
<li><a href="{{ site.baseurl }}/documentation/sdks/javadoc/" target="_blank">Java SDK API Reference <img src="{{ site.baseurl }}/images/external_link.png"
width="16" height="16"
alt="External link."></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image source and license?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this requires an attribution?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(no need for this, changed to different icon)

@asfbot
Copy link

asfbot commented Nov 22, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Test/112/
--none--

@asfbot
Copy link

asfbot commented Nov 22, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/156/

Jenkins built the site at commit id e9aabfb with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@asfbot
Copy link

asfbot commented Nov 23, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Test/116/
--none--

@asfbot
Copy link

asfbot commented Nov 23, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/160/

Jenkins built the site at commit id 4ba022a with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@davorbonaci
Copy link
Member

LGTM with a new icon from a different source. Merging.

@asfgit asfgit closed this in cb975b4 Nov 23, 2016
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants