-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small addition and fix #88
Conversation
hadarhg
commented
Nov 18, 2016
- Open Java SDK API Reference in new tab
- Add external link icon to Java SDK API Reference
- Fix header in WordCount Walkthrough
R: @davorbonaci |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): Jenkins built the site at commit id 85507ac with Jekyll and staged it here. Happy reviewing. Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -44,7 +44,10 @@ | |||
<li role="separator" class="divider"></li> | |||
<li class="dropdown-header">SDKs</li> | |||
<li><a href="{{ site.baseurl }}/documentation/sdks/java/">Java SDK</a></li> | |||
<li><a href="{{ site.baseurl }}/documentation/sdks/javadoc/">Java SDK API Reference</a></li> | |||
<li><a href="{{ site.baseurl }}/documentation/sdks/javadoc/" target="_blank">Java SDK API Reference <img src="{{ site.baseurl }}/images/external_link.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
javadoc/{{ site.release_latest }}
<li><a href="{{ site.baseurl }}/documentation/sdks/javadoc/">Java SDK API Reference</a></li> | ||
<li><a href="{{ site.baseurl }}/documentation/sdks/javadoc/" target="_blank">Java SDK API Reference <img src="{{ site.baseurl }}/images/external_link.png" | ||
width="16" height="16" | ||
alt="External link."></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image source and license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this requires an attribution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(no need for this, changed to different icon)
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): Jenkins built the site at commit id e9aabfb with Jekyll and staged it here. Happy reviewing. Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again. |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): Jenkins built the site at commit id 4ba022a with Jekyll and staged it here. Happy reviewing. Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again. |
LGTM with a new icon from a different source. Merging. |