Merge bfd16b4 into 6573e2e

apache · Jun 28, 2017 · 0a56c15 · 0a56c15
2 parents 6573e2e + bfd16b4
commit 0a56c15
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -571,7 +571,6 @@
         <artifactId>commons-lang3</artifactId>
         <version>${apache.commons.lang.version}</version>
       </dependency>
-
       <dependency>
         <groupId>org.apache.commons</groupId>
         <artifactId>commons-text</artifactId>

diff --git a/runners/spark/pom.xml b/runners/spark/pom.xml
@@ -221,6 +221,7 @@
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-text</artifactId>
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>commons-io</groupId>

diff --git a/sdks/java/core/pom.xml b/sdks/java/core/pom.xml
@@ -270,6 +270,13 @@
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-lang3</artifactId>
     </dependency>
+    <!-- Define commons-text dependency to include in the shaded jar -->
+    <dependency>
+      <groupId>org.apache.commons</groupId>
+      <artifactId>commons-text</artifactId>
+      <scope>runtime</scope>
+      <optional>true</optional>
+    </dependency>
 
     <dependency>
       <groupId>joda-time</groupId>

diff --git a/sdks/java/io/google-cloud-platform/pom.xml b/sdks/java/io/google-cloud-platform/pom.xml
@@ -258,13 +258,13 @@
       <artifactId>proto-google-common-protos</artifactId>
     </dependency>
 
+    <!--  Test dependencies -->
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-lang3</artifactId>
       <scope>provided</scope>
     </dependency>
 
-    <!--  Test dependencies -->
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-text</artifactId>

diff --git a/...oogle-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteIT.java b/...oogle-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteIT.java
@@ -149,7 +149,9 @@ public void testWrite() throws Exception {
 
   @After
   public void tearDown() throws Exception {
-    databaseAdminClient.dropDatabase(options.getInstanceId(), databaseName);
+    if (databaseAdminClient != null) {
+      databaseAdminClient.dropDatabase(options.getInstanceId(), databaseName);
+    }
     spanner.close();
   }