-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
11 changed files
with
551 additions
and
187 deletions.
There are no files selected for viewing
72 changes: 72 additions & 0 deletions
72
.../src/main/java/org/apache/beam/runners/core/construction/EmptyFlattenAsCreateFactory.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.beam.runners.core.construction; | ||
|
|
||
| import static com.google.common.base.Preconditions.checkArgument; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
| import org.apache.beam.sdk.Pipeline; | ||
| import org.apache.beam.sdk.coders.VoidCoder; | ||
| import org.apache.beam.sdk.runners.PTransformOverrideFactory; | ||
| import org.apache.beam.sdk.transforms.Create; | ||
| import org.apache.beam.sdk.transforms.Flatten; | ||
| import org.apache.beam.sdk.transforms.Flatten.FlattenPCollectionList; | ||
| import org.apache.beam.sdk.transforms.PTransform; | ||
| import org.apache.beam.sdk.values.PCollection; | ||
| import org.apache.beam.sdk.values.PCollectionList; | ||
| import org.apache.beam.sdk.values.PValue; | ||
| import org.apache.beam.sdk.values.TaggedPValue; | ||
|
|
||
| /** | ||
| * A {@link PTransformOverrideFactory} that provides an empty {@link Create} to replace a {@link | ||
| * Flatten.FlattenPCollectionList} that takes no input {@link PCollection PCollections}. | ||
| */ | ||
| public class EmptyFlattenAsCreateFactory<T> | ||
| implements PTransformOverrideFactory< | ||
| PCollectionList<T>, PCollection<T>, Flatten.FlattenPCollectionList<T>> { | ||
| private static final EmptyFlattenAsCreateFactory<Object> INSTANCE = | ||
| new EmptyFlattenAsCreateFactory<>(); | ||
|
|
||
| public static <T> EmptyFlattenAsCreateFactory<T> instance() { | ||
| return (EmptyFlattenAsCreateFactory<T>) INSTANCE; | ||
| } | ||
|
|
||
| private EmptyFlattenAsCreateFactory() {} | ||
|
|
||
| @Override | ||
| public PTransform<PCollectionList<T>, PCollection<T>> getReplacementTransform( | ||
| FlattenPCollectionList<T> transform) { | ||
| return (PTransform) Create.empty(VoidCoder.of()); | ||
| } | ||
|
|
||
| @Override | ||
| public PCollectionList<T> getInput( | ||
| List<TaggedPValue> inputs, Pipeline p) { | ||
| checkArgument( | ||
| inputs.isEmpty(), "Must have an empty input to use %s", getClass().getSimpleName()); | ||
| return PCollectionList.empty(p); | ||
| } | ||
|
|
||
| @Override | ||
| public Map<PValue, ReplacementOutput> mapOutputs( | ||
| List<TaggedPValue> outputs, PCollection<T> newOutput) { | ||
| return ReplacementOutputs.singleton(outputs, newOutput); | ||
| } | ||
| } |
50 changes: 50 additions & 0 deletions
50
...main/java/org/apache/beam/runners/core/construction/SingleInputOutputOverrideFactory.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.beam.runners.core.construction; | ||
|
|
||
| import com.google.common.collect.Iterables; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import org.apache.beam.sdk.Pipeline; | ||
| import org.apache.beam.sdk.runners.PTransformOverrideFactory; | ||
| import org.apache.beam.sdk.transforms.PTransform; | ||
| import org.apache.beam.sdk.values.PValue; | ||
| import org.apache.beam.sdk.values.TaggedPValue; | ||
|
|
||
| /** | ||
| * A {@link PTransformOverrideFactory} which consumes from a {@link PValue} and produces a | ||
| * {@link PValue}. {@link #getInput(List, Pipeline)} and {@link #mapOutputs(List, PValue)} are | ||
| * implemented. | ||
| */ | ||
| public abstract class SingleInputOutputOverrideFactory< | ||
| InputT extends PValue, | ||
| OutputT extends PValue, | ||
| TransformT extends PTransform<InputT, OutputT>> | ||
| implements PTransformOverrideFactory<InputT, OutputT, TransformT> { | ||
| @Override | ||
| public final InputT getInput(List<TaggedPValue> inputs, Pipeline p) { | ||
| return (InputT) Iterables.getOnlyElement(inputs).getValue(); | ||
| } | ||
|
|
||
| @Override | ||
| public final Map<PValue, ReplacementOutput> mapOutputs( | ||
| List<TaggedPValue> outputs, OutputT newOutput) { | ||
| return ReplacementOutputs.singleton(outputs, newOutput); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
114 changes: 114 additions & 0 deletions
114
.../java/org/apache/beam/runners/core/construction/SingleInputOutputOverrideFactoryTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.beam.runners.core.construction; | ||
|
|
||
| import static org.junit.Assert.assertThat; | ||
|
|
||
| import com.google.common.collect.Iterables; | ||
| import java.io.Serializable; | ||
| import java.util.Map; | ||
| import org.apache.beam.sdk.runners.PTransformOverrideFactory.ReplacementOutput; | ||
| import org.apache.beam.sdk.testing.TestPipeline; | ||
| import org.apache.beam.sdk.transforms.Create; | ||
| import org.apache.beam.sdk.transforms.MapElements; | ||
| import org.apache.beam.sdk.transforms.PTransform; | ||
| import org.apache.beam.sdk.transforms.SimpleFunction; | ||
| import org.apache.beam.sdk.values.PCollection; | ||
| import org.apache.beam.sdk.values.PCollectionList; | ||
| import org.apache.beam.sdk.values.PValue; | ||
| import org.hamcrest.Matchers; | ||
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
| import org.junit.rules.ExpectedException; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.JUnit4; | ||
|
|
||
| /** Tests for {@link SingleInputOutputOverrideFactory}. */ | ||
| @RunWith(JUnit4.class) | ||
| public class SingleInputOutputOverrideFactoryTest implements Serializable { | ||
| @Rule public transient ExpectedException thrown = ExpectedException.none(); | ||
|
|
||
| @Rule | ||
| public transient TestPipeline pipeline = | ||
| TestPipeline.create().enableAbandonedNodeEnforcement(false); | ||
|
|
||
| private transient SingleInputOutputOverrideFactory< | ||
| PCollection<? extends Integer>, PCollection<Integer>, MapElements<Integer, Integer>> | ||
| factory = | ||
| new SingleInputOutputOverrideFactory< | ||
| PCollection<? extends Integer>, PCollection<Integer>, | ||
| MapElements<Integer, Integer>>() { | ||
| @Override | ||
| public PTransform<PCollection<? extends Integer>, PCollection<Integer>> | ||
| getReplacementTransform(MapElements<Integer, Integer> transform) { | ||
| return transform; | ||
| } | ||
| }; | ||
|
|
||
| private SimpleFunction<Integer, Integer> fn = new SimpleFunction<Integer, Integer>() { | ||
| @Override | ||
| public Integer apply(Integer input) { | ||
| return input - 1; | ||
| } | ||
| }; | ||
|
|
||
| @Test | ||
| public void testGetInput() { | ||
| PCollection<Integer> input = pipeline.apply(Create.of(1, 2, 3)); | ||
| assertThat( | ||
| factory.getInput(input.expand(), pipeline), | ||
| Matchers.<PCollection<? extends Integer>>equalTo(input)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetInputMultipleInputsFails() { | ||
| PCollection<Integer> input = pipeline.apply(Create.of(1, 2, 3)); | ||
| PCollection<Integer> otherInput = pipeline.apply("OtherCreate", Create.of(1, 2, 3)); | ||
|
|
||
| thrown.expect(IllegalArgumentException.class); | ||
| factory.getInput(PCollectionList.of(input).and(otherInput).expand(), pipeline); | ||
| } | ||
|
|
||
| @Test | ||
| public void testMapOutputs() { | ||
| PCollection<Integer> input = pipeline.apply(Create.of(1, 2, 3)); | ||
| PCollection<Integer> output = input.apply("Map", MapElements.via(fn)); | ||
| PCollection<Integer> reappliedOutput = input.apply("ReMap", MapElements.via(fn)); | ||
| Map<PValue, ReplacementOutput> replacementMap = | ||
| factory.mapOutputs(output.expand(), reappliedOutput); | ||
| assertThat( | ||
| replacementMap, | ||
| Matchers.<PValue, ReplacementOutput>hasEntry( | ||
| reappliedOutput, | ||
| ReplacementOutput.of( | ||
| Iterables.getOnlyElement(output.expand()), | ||
| Iterables.getOnlyElement(reappliedOutput.expand())))); | ||
| } | ||
|
|
||
| @Test | ||
| public void testMapOutputsMultipleOriginalOutputsFails() { | ||
| PCollection<Integer> input = pipeline.apply(Create.of(1, 2, 3)); | ||
| PCollection<Integer> output = input.apply("Map", MapElements.via(fn)); | ||
| PCollection<Integer> reappliedOutput = input.apply("ReMap", MapElements.via(fn)); | ||
| thrown.expect(IllegalArgumentException.class); | ||
| Map<PValue, ReplacementOutput> replacementMap = | ||
| factory.mapOutputs( | ||
| PCollectionList.of(output).and(input).and(reappliedOutput).expand(), reappliedOutput); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.