Skip to content

Commit

Permalink
Addressed Mark's comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Boyuan Zhang committed Oct 4, 2018
1 parent b4cba24 commit 30296ce
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 16 deletions.
22 changes: 8 additions & 14 deletions runners/google-cloud-dataflow-java/worker/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,7 @@ configurations {

// Ban these dependencies from all configurations
all {
// Ban the usage of AppleJavaExtensions in findbugs since it can't be
// imported to google3 due to license issue.
// Ban the usage of AppleJavaExtensions in findbugs.
exclude group: "com.apple", module: "AppleJavaExtensions"
}
}
Expand Down Expand Up @@ -223,15 +222,10 @@ task extractSourceFiles(type: Copy) {
}
shadowJar.dependsOn extractSourceFiles

project.tasks.withType(Checkstyle) {
exclude '**/*.java'
}

project.tasks.withType(FindBugs) {
exclude '**/*.java'
classes = project.files([])
}

project.tasks.withType(Javadoc) {
exclude '**/*.java'
}
//TODO(BEAM-5657): checktyle task should be enabled in the future.
checkstyleMain.enabled = false
checkstyleTest.enabled = false
//TODO(BEAM-5658): fingbugs task should be enabled in the future.
findbugsMain.enabled = false
//TODO(BEAM-5659): javadoc task should be enabled in the future.
javadoc.enabled = false
4 changes: 2 additions & 2 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ include "beam-vendor-sdks-java-extensions-protobuf"
project(":beam-vendor-sdks-java-extensions-protobuf").dir = file("vendor/sdks-java-extensions-protobuf")
include "beam-website"
project(":beam-website").dir = file("website")
include "beam-runners-google-cloud-dataflow-java-worker-all"
project(":beam-runners-google-cloud-dataflow-java-worker-all").dir = file("runners/google-cloud-dataflow-java/worker")
include "beam-runners-google-cloud-dataflow-java-worker"
project(":beam-runners-google-cloud-dataflow-java-worker").dir = file("runners/google-cloud-dataflow-java/worker")
include "beam-runners-google-cloud-dataflow-java-windmill"
project(":beam-runners-google-cloud-dataflow-java-windmill").dir = file("runners/google-cloud-dataflow-java/worker/windmill")

0 comments on commit 30296ce

Please sign in to comment.