fixup! Address PR comments.

apache · Apr 28, 2017 · 7778f35 · 7778f35
1 parent de5669a
commit 7778f35
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystemRegistrar.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystemRegistrar.java
@@ -36,8 +36,8 @@ public interface FileSystemRegistrar {
   /**
    * Create zero or more {@link FileSystem filesystems} from the given {@link PipelineOptions}.
    *
-   * <p>The {@link FileSystem#getScheme() scheme} is required to be unique among all
-   * {@link FileSystemRegistrar FileSystemRegistrars}.
+   * <p>Each {@link FileSystem#getScheme() scheme} is required to be unique among all
+   * {@link FileSystem}s registered by all {@link FileSystemRegistrar}s.
    */
   List<FileSystem> fromOptions(@Nullable PipelineOptions options);
 }
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java
@@ -404,7 +404,7 @@ private static String parseScheme(String spec) {
   }
 
   /**
-   * Internal method to get {@link FileSystem} for {@code spec}.
+   * Internal method to get {@link FileSystem} for {@code scheme}.
    */
   @VisibleForTesting
   static FileSystem getFileSystemInternal(String scheme) {
@@ -425,7 +425,7 @@ static FileSystem getFileSystemInternal(String scheme) {
    *
    * <p>It will be used in {@link FileSystemRegistrar FileSystemRegistrars} for all schemes.
    */
-  public static void setDefaultConfigInWorkers(PipelineOptions options) {
+  public static synchronized void setDefaultConfigInWorkers(PipelineOptions options) {
     checkNotNull(options, "options");
     SCHEME_TO_FILESYSTEM.clear();
     Set<FileSystemRegistrar> registrars =